From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5A49E1FF146 for ; Tue, 28 Apr 2026 14:42:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19849129EB; Tue, 28 Apr 2026 14:42:15 +0200 (CEST) Message-ID: <98c57ffd-631f-4d4a-9c52-389cfc59f293@proxmox.com> Date: Tue, 28 Apr 2026 14:42:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup] ui: datastore content: always reload after namespace move From: Dominik Csapak To: pbs-devel@lists.proxmox.com References: <20260428122333.2920678-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20260428122333.2920678-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777380033403 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: 65FRXIZH3A4B5DYBWKSW44TCFEWUZWTN X-Message-ID-Hash: 65FRXIZH3A4B5DYBWKSW44TCFEWUZWTN X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/28/26 2:22 PM, Dominik Csapak wrote: > After a partial namespace move it could happen that some groups that > were in the current were actually moved, so reload the view and > namespace selector in any case. > > Signed-off-by: Dominik Csapak > --- > NOTE: this conflicts with my RFC for ns moving from parent: > https://lore.proxmox.com/pbs-devel/20260428111822.2471005-1-d.csapak@proxmox.com/T/#u > > but that patch would get a normal version anyway when we decide how to > handle the cases, so this patch could get applied already. the comment is actually wrong, it conflicts with my other patch i sent today : https://lore.proxmox.com/pbs-devel/1caf3dc4-cc7e-4560-b37d-642cbd89a533@proxmox.com/T/#t i'd send either one rebased once one of them is applied > > www/datastore/Content.js | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index b1e1f66cb..2c3aa6861 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -690,6 +690,11 @@ Ext.define('PBS.DataStoreContent', { > selector?.store?.load({ > callback: () => selector.setValue(newNs), > }); > + } else { > + // if we ran into an error, keep the current view, but > + // reload it and the namespace selector in case a new namespace was created > + view.down('pbsNamespaceSelector')?.store?.load(); > + me.reload(); > } > }, > });