public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] ui: datastore content: always reload after namespace move
Date: Tue, 28 Apr 2026 14:42:09 +0200	[thread overview]
Message-ID: <98c57ffd-631f-4d4a-9c52-389cfc59f293@proxmox.com> (raw)
In-Reply-To: <20260428122333.2920678-1-d.csapak@proxmox.com>



On 4/28/26 2:22 PM, Dominik Csapak wrote:
> After a partial namespace move it could happen that some groups that
> were in the current were actually moved, so reload the view and
> namespace selector in any case.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> NOTE: this conflicts with my RFC for ns moving from parent:
> https://lore.proxmox.com/pbs-devel/20260428111822.2471005-1-d.csapak@proxmox.com/T/#u
> 
> but that patch would get a normal version anyway when we decide how to
> handle the cases, so this patch could get applied already.

the comment is actually wrong, it conflicts with my other patch i sent
today : 
https://lore.proxmox.com/pbs-devel/1caf3dc4-cc7e-4560-b37d-642cbd89a533@proxmox.com/T/#t

i'd send either one rebased once one of them is applied
> 
>   www/datastore/Content.js | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index b1e1f66cb..2c3aa6861 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -690,6 +690,11 @@ Ext.define('PBS.DataStoreContent', {
>                           selector?.store?.load({
>                               callback: () => selector.setValue(newNs),
>                           });
> +                    } else {
> +                        // if we ran into an error, keep the current view, but
> +                        // reload it and the namespace selector in case a new namespace was created
> +                        view.down('pbsNamespaceSelector')?.store?.load();
> +                        me.reload();
>                       }
>                   },
>               });





  reply	other threads:[~2026-04-28 12:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 12:16 [PATCH proxmox-backup] ui: datastore content: always reload after namespace move Dominik Csapak
2026-04-28 12:42 ` Dominik Csapak [this message]
2026-04-28 13:18 ` superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98c57ffd-631f-4d4a-9c52-389cfc59f293@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal