Re: [PATCH proxmox-backup 17/28] api: backup: provide retain-until timestamp for extended prune protection

[Robert Obkircher <r.obkircher@proxmox.com>]

> Allows to protect snapshots from being pruned by providing a retention
> timestamp during backup.
> 
> Pruning must now also parse the manifest if present, which adds some
> additional overhead on snapshot forget operations. This is however not
> a performance critical code path as prunes run either in a job anyways,
> where a slight delay for each prune is acceptable or a single snapshot
> forget via API/CLI.
> 
> However, as a side effect manifests which cannot be parsed can no
> longer be pruned without manual intervention.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/pbs-datastore/src/backup_info.rs b/pbs-datastore/src/backup_info.rs
> index f476d4469..13eb0cdf6 100644
> --- a/pbs-datastore/src/backup_info.rs
> +++ b/pbs-datastore/src/backup_info.rs
> @@ -924,6 +924,17 @@ impl BackupDir {
>              bail!("cannot remove protected snapshot"); // use special error type?
>          }
>  
> +        if let Some((manifest, _size)) = self.load_manifest_optionally(false)? {
> +            if let Some(retain_until) = manifest.retention_timestamp()? {
> +                if retain_until > proxmox_time::epoch_i64() {
Probably completely irrelevant, but using `>` here shortens the orignal
timespan by up to 1 second (if retain_until was computed right before
epoch_i64 increased).

-- 
Robert Obkircher <r.obkircher@proxmox.com>