[PATCH proxmox-backup 08/28] client: avoid error in status if user lacks permissions

[Christian Ebner <c.ebner@proxmox.com>]

In case of missing permissions the total storage space will be
returned as zero, leading to the status output not being rendered
since protected from zero division.

This is however neither user friendly as the error does not reflect
there being a lack of permissions, nor is it the correct behaviour,
since the user still might have access to other information such as
snapshot count (although currently not exposed in the CLI).

Fix this by showing the values as returned by the API and skipping
the percentage display if this would lead to zero division.

While at it, rename the closure to reflect this behaviour and convert
value parsing issues to errors instead of panics.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-backup-client/src/main.rs | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index e77661b22..ab77f0bbf 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -2082,23 +2082,27 @@ async fn status(param: Value) -> Result<Value, Error> {
 
     record_repository(&repo);
 
-    let render_total_percentage = |v: &Value, record: &Value| -> Result<String, Error> {
-        let v = v.as_u64().unwrap();
-        let total = record["total"].as_u64().unwrap();
+    let total_with_opt_percentage = |v: &Value, record: &Value| -> Result<String, Error> {
+        let v = v
+            .as_u64()
+            .ok_or_else(|| format_err!("value is not a number"))?;
+        let total = record["total"]
+            .as_u64()
+            .ok_or_else(|| format_err!("total is not a number"))?;
         let roundup = total / 200;
         if let Some(per) = ((v + roundup) * 100).checked_div(total) {
             let info = format!(" ({per} %)");
             Ok(format!("{v} {info:>8}"))
         } else {
-            bail!("Cannot render total percentage: denominator is zero");
+            Ok(v.to_string())
         }
     };
 
     let options = default_table_format_options()
         .noheader(true)
-        .column(ColumnConfig::new("total").renderer(render_total_percentage))
-        .column(ColumnConfig::new("used").renderer(render_total_percentage))
-        .column(ColumnConfig::new("avail").renderer(render_total_percentage));
+        .column(ColumnConfig::new("total").renderer(total_with_opt_percentage))
+        .column(ColumnConfig::new("used").renderer(total_with_opt_percentage))
+        .column(ColumnConfig::new("avail").renderer(total_with_opt_percentage));
 
     let return_type = &API_METHOD_STATUS.returns;
 
-- 
2.47.3