Re: [PATCH proxmox-backup 24/28] ui: add retention timespan form and use it for sync job edit window

[Robert Obkircher <r.obkircher@proxmox.com>]

> Based on the calender event form, the retention timespan form
> provides some useful template values for snapshot retention to
> be set on sync jobs.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/www/Makefile b/www/Makefile
> index 568836455..e14a17507 100644
> --- a/www/Makefile
> +++ b/www/Makefile
> @@ -56,6 +56,7 @@ JSSRC=							\
>  	form/GroupFilter.js				\
>  	form/VerifyOutdatedAfter.js			\
>  	form/EncryptionKeySelector.js			\
> +	form/RetentionTimespan.js			\
>  	data/RunningTasksStore.js			\
>  	button/TaskButton.js				\
>  	panel/PrunePanel.js				\
> diff --git a/www/form/RetentionTimespan.js b/www/form/RetentionTimespan.js
> new file mode 100644
> index 000000000..9a84c59a2
> --- /dev/null
> +++ b/www/form/RetentionTimespan.js
> @@ -0,0 +1,21 @@
> +Ext.define('PBS.data.RetentionTimespanTemplates', {
> +    extend: 'Ext.data.Store',
> +    alias: 'store.retentionTimespanTemplates',
> +
> +    field: ['value', 'text'],
> +    data: [
> +        { value: '1 day', text: Ext.String.format(gettext('Retain for {0} day'), 1) },
> +        { value: '4 weeks', text: Ext.String.format(gettext('Retain for {0} weeks'), 4) },
> +        { value: '1 month', text: Ext.String.format(gettext('Retain for {0} month'), 1) },
> +        { value: '1 year', text: Ext.String.format(gettext('Retain for {0} year'), 1) },
nit: The "Retain for " prefix sounds a bit off to me, when selecting
the maximum retention timespan.

-- 
Robert Obkircher <r.obkircher@proxmox.com>