all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>,
	<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH cluster v2 2/2] fix #5475: configurable window title
Date: Wed, 22 Jul 2026 13:23:52 +0200	[thread overview]
Message-ID: <DK528KJTQ52M.AUCSLZ3BJA82@proxmox.com> (raw)
In-Reply-To: <DK519SGP6J59.23N721U5BG0NZ@proxmox.com>

Thanks for your review, I'm addressing the issues on the other patch
right now!

On Wed Jul 22, 2026 at 12:38 PM CEST, Elias Huhsovitz wrote:

[snip]

>> +my $ui_settings_format = {
>> +    'title' => {
> nit: The 'title' in the ui_settings_format might be a bit vagaue, since the
> format might be used in future UI settings. Perhaps some thing like
> 'page-title' or 'tab-title' might be better suited. But this is very
> pedantic of me.

For this one, I had it as 'window-title' before, but with the suggestion
to create the 'ui-settings' format string, @Thomas Lamprecht [1] also
mentioned changing the 'window-title' name to just 'title' which I
found fitting.

[1]: https://lore.proxmox.com/pve-devel/3f04e2b9-d39f-4604-b169-c3ae530256af@proxmox.com/

[snip]




      reply	other threads:[~2026-07-22 11:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 10:03 [PATCH cluster/manager v2 0/2] Configurable window titles for nodes Thomas Ellmenreich
2026-07-20 10:03 ` [PATCH manager v2 1/2] fix #5475: configurable window title Thomas Ellmenreich
2026-07-22 10:27   ` Elias Huhsovitz
2026-07-22 12:43     ` Thomas Ellmenreich
2026-07-22 14:49       ` Elias Huhsovitz
2026-07-20 10:03 ` [PATCH cluster v2 2/2] " Thomas Ellmenreich
2026-07-22 10:38   ` Elias Huhsovitz
2026-07-22 11:23     ` Thomas Ellmenreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK528KJTQ52M.AUCSLZ3BJA82@proxmox.com \
    --to=t.ellmenreich@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal