Re: [PATCH cluster 2/2] fix #5475: configurable window title

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 16.07.26 um 10:49 schrieb Thomas Ellmenreich:
> Added new configuration option that will determine the content
> of the window title for a pve-manager tab.
> 
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..6f3f482 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -436,6 +436,13 @@ my $datacenter_schema = {
>              # FIXME: remove 'applet' with 9.0 (add pve8to9 check!)
>              enum => ['applet', 'vv', 'html5', 'xtermjs'],
>          },
> +        'window-title' => {
> +            optional => 1,
> +            type => 'string',
> +            description =>
> +                "Define the text shown in the window title for all nodes of this cluster",
> +            enum => ['node-and-cluster', 'fqdn'],
> +        },

The window term is a bit opaque here in the backend, but can be fine..

Would favor using a format here from the start to make this easier to expand, e.g.
I could imagine adding support for passing a color that gets rendered in the favicon
e.g. as circle or corner for some differentiating from that side, or a prefix/suffix
added to the title.  Needs more thought, and we can expand such things later true our
default-key schema support, but might be nicer to start out already with a format
now already.

we could do a more general "ui" or "ui-settings" one to see this from a global UI
settings POV? and then there simply "title" or as property.

>          email_from => {
>              optional => 1,
>              type => 'string',