Re: [PATCH cluster v2 2/2] fix #5475: configurable window title

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

The new setting matches the existing format well.
See 1 nit below. 

That being said:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Mon Jul 20, 2026 at 12:03 PM CEST, Thomas Ellmenreich wrote:
> Added a new 'ui-settings' format string to the datacenter.cfg. Currently
> only contains a 'title' option to determine the window title of the
> nodes browser tab.
>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..751d8ed 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -344,6 +344,16 @@ my $user_tag_privs_format = {
>      },
>  };
>  
> +my $ui_settings_format = {
> +    'title' => {
nit: The 'title' in the ui_settings_format might be a bit vagaue, since the
format might be used in future UI settings. Perhaps some thing like
'page-title' or 'tab-title' might be better suited. But this is very
pedantic of me.
> +        optional => 1,
> +        type => 'string',
> +        enum => ['node-and-cluster', 'fqdn'],
> +        description =>
> +            "Define the text displayed in the browser tab title for all nodes in this cluster.",
> +    },
> +};
> +
>  my $datacenter_schema = {
>      type => "object",
>      additionalProperties => 0,
> @@ -436,6 +446,12 @@ my $datacenter_schema = {
>              # FIXME: remove 'applet' with 9.0 (add pve8to9 check!)
>              enum => ['applet', 'vv', 'html5', 'xtermjs'],
>          },
> +        'ui-settings' => {
> +            optional => 1,
> +            type => "string",
> +            format => $ui_settings_format,
> +            description => "For cluster wide ui settings.",
> +        },
>          email_from => {
>              optional => 1,
>              type => 'string',
> @@ -618,6 +634,10 @@ sub parse_datacenter_config {
>          $res->{'tag-style'} = parse_property_string($tag_style_format, $tag_style);
>      }
>  
> +    if (my $ui_settings = $res->{'ui-settings'}) {
> +        $res->{'ui-settings'} = parse_property_string($ui_settings_format, $ui_settings);
> +    }
> +
>      if (my $user_tag_privs = $res->{'user-tag-access'}) {
>          $res->{'user-tag-access'} = parse_property_string($user_tag_privs_format, $user_tag_privs);
>  
> @@ -711,6 +731,11 @@ sub write_datacenter_config {
>          $cfg->{'tag-style'} = PVE::JSONSchema::print_property_string($tag_style, $tag_style_format);
>      }
>  
> +    if (ref(my $ui_settings = $cfg->{'ui-settings'})) {
> +        $cfg->{'ui-settings'} =
> +            PVE::JSONSchema::print_property_string($ui_settings, $ui_settings_format);
> +    }
> +
>      if (ref(my $user_tag_privs = $cfg->{'user-tag-access'})) {
>          if (my $user_tags = $user_tag_privs->{'user-allow-list'}) {
>              $user_tag_privs->{'user-allow-list'} = join(';', sort $user_tags->@*);