Re: [PATCH manager v2 1/2] fix #5475: configurable window title

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

A few comments adressing 1. & 3.

On Wed Jul 22, 2026 at 2:43 PM CEST, Thomas Ellmenreich wrote:
> Thanks again for your review. I realised I had a question here as well.
>
> [snip]
>
>> 1. The setting names render including the $ symbol, e.g. ($nodename, $fqdn) in the WebUI. 
>> This makes it seem broken from an end user point of view. 
>> You generally do not expect placeholder values in settings menu.
>
> Rendering the '$' was on purpose, as they are placeholders. Would you
> recommend removing just the '$' or would you rather render the actual
> values?
>
> I technically copied it from somewhere, as I had a different placeholder
> marker, although I can't seem to find that reference anymore.

While using $ is a standard programming convention for variables, 
displaying it literally in a user-facing dropdown 
(e.g., $nodename - Proxmox Virtual Environment) 
can look like a broken string interpolation or a rendering bug to an end user. 

Instead of showing the template string, my suggestions would be
descriptive labels for the items, e.g.:
* __default__ -> "Node Name (Default)"
* node-and-cluster -> "Node and Cluster Name"
* fqdn -> Fully Qualified Domain Name (FQDN)

>> 3. I recommend adding some general robustness in case of undef values:
>> Initialize $window_title to a safe value not relying on the cluster, in
>> case of an error. Expect that the underlying API/calls might return
>> undef.
>
> It was an active choice to show something broken in the case of undef, as I
> thought hiding the error could also be confusing. But then again, I don't mind
> using the fallback value.

IMO the problem is that the undef might get dereference and cause a 'die' 
potentially aborting the entire entire eval block in pveproy.pm:255.

I would advocate for "graceful" degradation:
- add a defined check to prevent the crash
- initialize the $window_title with a safe default.

You can also add a warn statement inside the subroutine so it does not
fail silently.