From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH cluster v2 2/2] fix #5475: configurable window title
Date: Mon, 20 Jul 2026 12:03:29 +0200 [thread overview]
Message-ID: <20260720100329.118508-3-t.ellmenreich@proxmox.com> (raw)
In-Reply-To: <20260720100329.118508-1-t.ellmenreich@proxmox.com>
Added a new 'ui-settings' format string to the datacenter.cfg. Currently
only contains a 'title' option to determine the window title of the
nodes browser tab.
Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
src/PVE/DataCenterConfig.pm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index 004122e..751d8ed 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
@@ -344,6 +344,16 @@ my $user_tag_privs_format = {
},
};
+my $ui_settings_format = {
+ 'title' => {
+ optional => 1,
+ type => 'string',
+ enum => ['node-and-cluster', 'fqdn'],
+ description =>
+ "Define the text displayed in the browser tab title for all nodes in this cluster.",
+ },
+};
+
my $datacenter_schema = {
type => "object",
additionalProperties => 0,
@@ -436,6 +446,12 @@ my $datacenter_schema = {
# FIXME: remove 'applet' with 9.0 (add pve8to9 check!)
enum => ['applet', 'vv', 'html5', 'xtermjs'],
},
+ 'ui-settings' => {
+ optional => 1,
+ type => "string",
+ format => $ui_settings_format,
+ description => "For cluster wide ui settings.",
+ },
email_from => {
optional => 1,
type => 'string',
@@ -618,6 +634,10 @@ sub parse_datacenter_config {
$res->{'tag-style'} = parse_property_string($tag_style_format, $tag_style);
}
+ if (my $ui_settings = $res->{'ui-settings'}) {
+ $res->{'ui-settings'} = parse_property_string($ui_settings_format, $ui_settings);
+ }
+
if (my $user_tag_privs = $res->{'user-tag-access'}) {
$res->{'user-tag-access'} = parse_property_string($user_tag_privs_format, $user_tag_privs);
@@ -711,6 +731,11 @@ sub write_datacenter_config {
$cfg->{'tag-style'} = PVE::JSONSchema::print_property_string($tag_style, $tag_style_format);
}
+ if (ref(my $ui_settings = $cfg->{'ui-settings'})) {
+ $cfg->{'ui-settings'} =
+ PVE::JSONSchema::print_property_string($ui_settings, $ui_settings_format);
+ }
+
if (ref(my $user_tag_privs = $cfg->{'user-tag-access'})) {
if (my $user_tags = $user_tag_privs->{'user-allow-list'}) {
$user_tag_privs->{'user-allow-list'} = join(';', sort $user_tags->@*);
--
2.47.3
prev parent reply other threads:[~2026-07-20 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 10:03 [PATCH cluster/manager v2 0/2] Configurable window titles for nodes Thomas Ellmenreich
2026-07-20 10:03 ` [PATCH manager v2 1/2] fix #5475: configurable window title Thomas Ellmenreich
2026-07-20 10:03 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720100329.118508-3-t.ellmenreich@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.