From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D4B401FF138 for ; Mon, 20 Jul 2026 12:03:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 54A0221470; Mon, 20 Jul 2026 12:03:37 +0200 (CEST) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v2 2/2] fix #5475: configurable window title Date: Mon, 20 Jul 2026 12:03:29 +0200 Message-ID: <20260720100329.118508-3-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260720100329.118508-1-t.ellmenreich@proxmox.com> References: <20260720100329.118508-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784541788532 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.200 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Z6B45QI5ILBQ3NLVOIDNQXRT26UVR7XF X-Message-ID-Hash: Z6B45QI5ILBQ3NLVOIDNQXRT26UVR7XF X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Added a new 'ui-settings' format string to the datacenter.cfg. Currently only contains a 'title' option to determine the window title of the nodes browser tab. Signed-off-by: Thomas Ellmenreich --- src/PVE/DataCenterConfig.pm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index 004122e..751d8ed 100644 --- a/src/PVE/DataCenterConfig.pm +++ b/src/PVE/DataCenterConfig.pm @@ -344,6 +344,16 @@ my $user_tag_privs_format = { }, }; +my $ui_settings_format = { + 'title' => { + optional => 1, + type => 'string', + enum => ['node-and-cluster', 'fqdn'], + description => + "Define the text displayed in the browser tab title for all nodes in this cluster.", + }, +}; + my $datacenter_schema = { type => "object", additionalProperties => 0, @@ -436,6 +446,12 @@ my $datacenter_schema = { # FIXME: remove 'applet' with 9.0 (add pve8to9 check!) enum => ['applet', 'vv', 'html5', 'xtermjs'], }, + 'ui-settings' => { + optional => 1, + type => "string", + format => $ui_settings_format, + description => "For cluster wide ui settings.", + }, email_from => { optional => 1, type => 'string', @@ -618,6 +634,10 @@ sub parse_datacenter_config { $res->{'tag-style'} = parse_property_string($tag_style_format, $tag_style); } + if (my $ui_settings = $res->{'ui-settings'}) { + $res->{'ui-settings'} = parse_property_string($ui_settings_format, $ui_settings); + } + if (my $user_tag_privs = $res->{'user-tag-access'}) { $res->{'user-tag-access'} = parse_property_string($user_tag_privs_format, $user_tag_privs); @@ -711,6 +731,11 @@ sub write_datacenter_config { $cfg->{'tag-style'} = PVE::JSONSchema::print_property_string($tag_style, $tag_style_format); } + if (ref(my $ui_settings = $cfg->{'ui-settings'})) { + $cfg->{'ui-settings'} = + PVE::JSONSchema::print_property_string($ui_settings, $ui_settings_format); + } + if (ref(my $user_tag_privs = $cfg->{'user-tag-access'})) { if (my $user_tags = $user_tag_privs->{'user-allow-list'}) { $user_tag_privs->{'user-allow-list'} = join(';', sort $user_tags->@*); -- 2.47.3