all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off
@ 2026-11-20 15:15 Dominik Csapak
  2026-11-20 15:15 ` [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left Dominik Csapak
  2026-11-20 15:15 ` [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Dominik Csapak
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-11-20 15:15 UTC (permalink / raw)
  To: pve-devel

With the unique ID row, the status panel of a container no longer fits
into the fixed height it shares with the notes, so its last rows (e.g.
the 'More' button of the IPs) are cut off.

The pve-manager patch lets the status panel set the height of that row
and keeps a minimum height for the notes, which still scroll instead of
growing the row.

Since the row can now be taller than the charts next to it, the charts
of the next row got caught on it with multiple columns and ended up in
the wrong column. The widget-toolkit patch fixes that for all column
layouts that use updateColumnWidth by starting each row at the left. It
does so with 'columnCount', an undocumented, internal property of the
ExtJS column layout.

The pve-manager patch needs the widget-toolkit patch for a correct
chart layout with multiple columns.

Alternatively we could of course increase the height of all panels,
but that would was space for guests without a guest agent for example.

proxmox-widget-toolkit:

Dominik Csapak (1):
  utils: update column width: start each row at the left

 src/Utils.js | 5 +++++
 1 file changed, 5 insertions(+)


pve-manager:

Dominik Csapak (1):
  ui: guest summary: let the status panel set the height of its row

 www/manager6/panel/GuestStatusView.js | 4 ++++
 www/manager6/panel/GuestSummary.js    | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)


Summary over all repositories:
  3 files changed, 13 insertions(+), 2 deletions(-)

-- 
Generated by murpp 0.11.0




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left
  2026-11-20 15:15 [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off Dominik Csapak
@ 2026-11-20 15:15 ` Dominik Csapak
  2026-11-20 15:15 ` [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Dominik Csapak
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-11-20 15:15 UTC (permalink / raw)
  To: pve-devel

The summary and dashboard panels float their items in a column layout.
If an item is taller than the others of its row, the first item of the
next row gets caught on it and ends up further right, which moves all
following items over by one column. This happens, for example, with
the status panel of a guest summary in Proxmox VE, which grows with
its content.

Set the column count of the layout to the number of columns, which
makes it clear the float of the first item of each row. Note that
'columnCount' is an undocumented, internal property of the ExtJS
column layout, so this relies on its implementation.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/Utils.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/Utils.js b/src/Utils.js
index 6fa0a24..5b01ee2 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -694,6 +694,11 @@ Ext.define('Proxmox.Utils', {
             items.forEach((item) => {
                 item.columnWidth = 1 / factor;
             });
+            // Start each row at the left, the floated items would otherwise get caught on a
+            // taller item of the row above. This is a hack: 'columnCount' is an undocumented,
+            // internal property of the ExtJS column layout. If set, the layout gives each item
+            // whose index is a multiple of it 'clear: left' and removes 'clear' from the others.
+            container.getLayout().columnCount = factor;
 
             // we have to update the layout twice, since the first layout change
             // can trigger the scrollbar which reduces the amount of space left
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row
  2026-11-20 15:15 [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off Dominik Csapak
  2026-11-20 15:15 ` [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left Dominik Csapak
@ 2026-11-20 15:15 ` Dominik Csapak
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-11-20 15:15 UTC (permalink / raw)
  To: pve-devel

The status panel and the notes share a row with a fixed height. With
the unique ID row, the status panel of a container no longer fits into
it and its last rows are cut off.

Let the row grow with the status panel instead. The notes get a fixed
height, which the row stretches if the status panel is taller, so it
acts as a minimum, and long notes still scroll instead of growing the
row. Add a spacer below the last row of the status panel, as it now
ends right after that row if it sets the height.

To prevent the charts getting caught on the taller row and
end up in the wrong column, a new widget toolkit is needed.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/panel/GuestStatusView.js | 4 ++++
 www/manager6/panel/GuestSummary.js    | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 00851b07..a00b0b4f 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -172,6 +172,10 @@ Ext.define('PVE.panel.GuestStatusView', {
                 pveSelNode: '{pveSelNode}',
             },
         },
+        {
+            xtype: 'box',
+            height: 20,
+        },
     ],
 
     updateTitle: function () {
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 9c634775..6a87eb41 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -64,6 +64,9 @@ Ext.define('PVE.guest.Summary', {
                 xtype: 'pmxNotesView',
                 flex: 1,
                 padding: template ? '5' : '0 0 0 5',
+                // the row stretches it to the status view if that is taller, so this acts as a
+                // minimum, and long notes scroll instead of growing the row
+                height: template ? undefined : 350,
                 itemId: 'notesview',
                 pveSelNode: me.pveSelNode,
             },
@@ -75,10 +78,9 @@ Ext.define('PVE.guest.Summary', {
             items = [
                 {
                     xtype: 'container',
-                    height: 300,
                     layout: {
                         type: 'hbox',
-                        align: 'stretch',
+                        align: 'stretchmax',
                     },
                     items: items,
                 },
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 15:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 15:15 [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off Dominik Csapak
2026-11-20 15:15 ` [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left Dominik Csapak
2026-11-20 15:15 ` [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Dominik Csapak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal