all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left
Date: Fri, 20 Nov 2026 16:15:13 +0100	[thread overview]
Message-ID: <20261120151518.3386028-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261120151518.3386028-1-d.csapak@proxmox.com>

The summary and dashboard panels float their items in a column layout.
If an item is taller than the others of its row, the first item of the
next row gets caught on it and ends up further right, which moves all
following items over by one column. This happens, for example, with
the status panel of a guest summary in Proxmox VE, which grows with
its content.

Set the column count of the layout to the number of columns, which
makes it clear the float of the first item of each row. Note that
'columnCount' is an undocumented, internal property of the ExtJS
column layout, so this relies on its implementation.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/Utils.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/Utils.js b/src/Utils.js
index 6fa0a24..5b01ee2 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -694,6 +694,11 @@ Ext.define('Proxmox.Utils', {
             items.forEach((item) => {
                 item.columnWidth = 1 / factor;
             });
+            // Start each row at the left, the floated items would otherwise get caught on a
+            // taller item of the row above. This is a hack: 'columnCount' is an undocumented,
+            // internal property of the ExtJS column layout. If set, the layout gives each item
+            // whose index is a multiple of it 'clear: left' and removes 'clear' from the others.
+            container.getLayout().columnCount = factor;
 
             // we have to update the layout twice, since the first layout change
             // can trigger the scrollbar which reduces the amount of space left
-- 
2.47.3





  reply	other threads:[~2026-11-20 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:15 [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off Dominik Csapak
2026-11-20 15:15 ` Dominik Csapak [this message]
2026-11-20 15:15 ` [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120151518.3386028-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal