From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row
Date: Fri, 20 Nov 2026 16:15:14 +0100 [thread overview]
Message-ID: <20261120151518.3386028-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261120151518.3386028-1-d.csapak@proxmox.com>
The status panel and the notes share a row with a fixed height. With
the unique ID row, the status panel of a container no longer fits into
it and its last rows are cut off.
Let the row grow with the status panel instead. The notes get a fixed
height, which the row stretches if the status panel is taller, so it
acts as a minimum, and long notes still scroll instead of growing the
row. Add a spacer below the last row of the status panel, as it now
ends right after that row if it sets the height.
To prevent the charts getting caught on the taller row and
end up in the wrong column, a new widget toolkit is needed.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/panel/GuestStatusView.js | 4 ++++
www/manager6/panel/GuestSummary.js | 6 ++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 00851b07..a00b0b4f 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -172,6 +172,10 @@ Ext.define('PVE.panel.GuestStatusView', {
pveSelNode: '{pveSelNode}',
},
},
+ {
+ xtype: 'box',
+ height: 20,
+ },
],
updateTitle: function () {
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 9c634775..6a87eb41 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -64,6 +64,9 @@ Ext.define('PVE.guest.Summary', {
xtype: 'pmxNotesView',
flex: 1,
padding: template ? '5' : '0 0 0 5',
+ // the row stretches it to the status view if that is taller, so this acts as a
+ // minimum, and long notes scroll instead of growing the row
+ height: template ? undefined : 350,
itemId: 'notesview',
pveSelNode: me.pveSelNode,
},
@@ -75,10 +78,9 @@ Ext.define('PVE.guest.Summary', {
items = [
{
xtype: 'container',
- height: 300,
layout: {
type: 'hbox',
- align: 'stretch',
+ align: 'stretchmax',
},
items: items,
},
--
2.47.3
prev parent reply other threads:[~2026-11-20 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:15 [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off Dominik Csapak
2026-11-20 15:15 ` [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left Dominik Csapak
2026-11-20 15:15 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120151518.3386028-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.