From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3DF751FF0AF for ; Fri, 20 Nov 2026 16:15:25 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CD530217C7; Fri, 20 Nov 2026 16:15:22 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Date: Fri, 20 Nov 2026 16:15:14 +0100 Message-ID: <20261120151518.3386028-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120151518.3386028-1-d.csapak@proxmox.com> References: <20261120151518.3386028-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.267 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 76EKERAXHYV4TME6KYGZD42WEYN7BJX7 X-Message-ID-Hash: 76EKERAXHYV4TME6KYGZD42WEYN7BJX7 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The status panel and the notes share a row with a fixed height. With the unique ID row, the status panel of a container no longer fits into it and its last rows are cut off. Let the row grow with the status panel instead. The notes get a fixed height, which the row stretches if the status panel is taller, so it acts as a minimum, and long notes still scroll instead of growing the row. Add a spacer below the last row of the status panel, as it now ends right after that row if it sets the height. To prevent the charts getting caught on the taller row and end up in the wrong column, a new widget toolkit is needed. Signed-off-by: Dominik Csapak --- www/manager6/panel/GuestStatusView.js | 4 ++++ www/manager6/panel/GuestSummary.js | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js index 00851b07..a00b0b4f 100644 --- a/www/manager6/panel/GuestStatusView.js +++ b/www/manager6/panel/GuestStatusView.js @@ -172,6 +172,10 @@ Ext.define('PVE.panel.GuestStatusView', { pveSelNode: '{pveSelNode}', }, }, + { + xtype: 'box', + height: 20, + }, ], updateTitle: function () { diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js index 9c634775..6a87eb41 100644 --- a/www/manager6/panel/GuestSummary.js +++ b/www/manager6/panel/GuestSummary.js @@ -64,6 +64,9 @@ Ext.define('PVE.guest.Summary', { xtype: 'pmxNotesView', flex: 1, padding: template ? '5' : '0 0 0 5', + // the row stretches it to the status view if that is taller, so this acts as a + // minimum, and long notes scroll instead of growing the row + height: template ? undefined : 350, itemId: 'notesview', pveSelNode: me.pveSelNode, }, @@ -75,10 +78,9 @@ Ext.define('PVE.guest.Summary', { items = [ { xtype: 'container', - height: 300, layout: { type: 'hbox', - align: 'stretch', + align: 'stretchmax', }, items: items, }, -- 2.47.3