[PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[Fiona Ebner]

Since the $noerr parameter was not passed along, the get_pkg
subroutine would log a failure when it couldn't determine the
installed package version for old kernel metapackages, e.g.:
> FAIL: unable to determine installed pve-kernel-6.5 version.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/CLI/pve8to9.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 6512ff44..02d13f0e 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -259,7 +259,7 @@ sub check_pve_packages {
             my $outdated_kernel_meta_pkgs = [];
             for my $kernel_meta_version ('6.2', '6.5', '6.8', '6.11') {
                 my $pkg = "pve-kernel-${kernel_meta_version}";
-                if ($get_pkg->($pkg)) {
+                if ($get_pkg->($pkg, 1)) {
                     push @$outdated_kernel_meta_pkgs, $pkg;
                 }
             }
-- 
2.47.3

Re: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[Shannon Sterz]

On Tue May 19, 2026 at 10:50 AM CEST, Fiona Ebner wrote:
> Since the $noerr parameter was not passed along, the get_pkg
> subroutine would log a failure when it couldn't determine the
> installed package version for old kernel metapackages, e.g.:
>> FAIL: unable to determine installed pve-kernel-6.5 version.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/CLI/pve8to9.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 6512ff44..02d13f0e 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -259,7 +259,7 @@ sub check_pve_packages {
>              my $outdated_kernel_meta_pkgs = [];
>              for my $kernel_meta_version ('6.2', '6.5', '6.8', '6.11') {
>                  my $pkg = "pve-kernel-${kernel_meta_version}";
> -                if ($get_pkg->($pkg)) {
> +                if ($get_pkg->($pkg, 1)) {
>                      push @$outdated_kernel_meta_pkgs, $pkg;
>                  }
>              }

lgtm and also work for me, so consider this:

Tested-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>

applied: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[Fabian Grünbichler]

On Tue, 19 May 2026 10:50:06 +0200, Fiona Ebner wrote:
> Since the $noerr parameter was not passed along, the get_pkg
> subroutine would log a failure when it couldn't determine the
> installed package version for old kernel metapackages, e.g.:
> > FAIL: unable to determine installed pve-kernel-6.5 version.
> 
> 

Applied to master and stable-8, thanks!

[1/1] pve8to9: avoid logging failure when old kernel metapackages are not installed
      commit: 2385f49c54c452f7676efe8f9296335917db060e

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>

Re: applied: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[Fiona Ebner]

Am 19.05.26 um 2:19 PM schrieb Fabian Grünbichler:
> 
> On Tue, 19 May 2026 10:50:06 +0200, Fiona Ebner wrote:
>> Since the $noerr parameter was not passed along, the get_pkg
>> subroutine would log a failure when it couldn't determine the
>> installed package version for old kernel metapackages, e.g.:
>>> FAIL: unable to determine installed pve-kernel-6.5 version.
>>
>>
> 
> Applied to master and stable-8, thanks!

In stable-8, $get_pkg() does not have the $noerr argument yet.

Re: applied: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed

[Fabian Grünbichler]

On May 19, 2026 2:27 pm, Fiona Ebner wrote:
> Am 19.05.26 um 2:19 PM schrieb Fabian Grünbichler:
>> 
>> On Tue, 19 May 2026 10:50:06 +0200, Fiona Ebner wrote:
>>> Since the $noerr parameter was not passed along, the get_pkg
>>> subroutine would log a failure when it couldn't determine the
>>> installed package version for old kernel metapackages, e.g.:
>>>> FAIL: unable to determine installed pve-kernel-6.5 version.
>>>
>>>
>> 
>> Applied to master and stable-8, thanks!
> 
> In stable-8, $get_pkg() does not have the $noerr argument yet.

thanks, added that as a follow-up!