all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed
Date: Tue, 19 May 2026 13:51:52 +0200	[thread overview]
Message-ID: <DIMMR52ITX9B.35MCX6IQJDQXD@proxmox.com> (raw)
In-Reply-To: <20260519085148.42853-1-f.ebner@proxmox.com>

On Tue May 19, 2026 at 10:50 AM CEST, Fiona Ebner wrote:
> Since the $noerr parameter was not passed along, the get_pkg
> subroutine would log a failure when it couldn't determine the
> installed package version for old kernel metapackages, e.g.:
>> FAIL: unable to determine installed pve-kernel-6.5 version.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/CLI/pve8to9.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 6512ff44..02d13f0e 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -259,7 +259,7 @@ sub check_pve_packages {
>              my $outdated_kernel_meta_pkgs = [];
>              for my $kernel_meta_version ('6.2', '6.5', '6.8', '6.11') {
>                  my $pkg = "pve-kernel-${kernel_meta_version}";
> -                if ($get_pkg->($pkg)) {
> +                if ($get_pkg->($pkg, 1)) {
>                      push @$outdated_kernel_meta_pkgs, $pkg;
>                  }
>              }

lgtm and also work for me, so consider this:

Tested-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>




  reply	other threads:[~2026-05-19 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  8:50 [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed Fiona Ebner
2026-05-19 11:51 ` Shannon Sterz [this message]
2026-05-19 12:19 ` applied: " Fabian Grünbichler
2026-05-19 12:27   ` Fiona Ebner
2026-05-19 12:40     ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIMMR52ITX9B.35MCX6IQJDQXD@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal