From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 062141FF141 for ; Tue, 19 May 2026 13:51:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 97DFC48D5; Tue, 19 May 2026 13:51:55 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 19 May 2026 13:51:52 +0200 Message-Id: Subject: Re: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20260519085148.42853-1-f.ebner@proxmox.com> In-Reply-To: <20260519085148.42853-1-f.ebner@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779191498745 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GMKHGDMXH5Y2R6PRGSLTPFFNBR54WRJ5 X-Message-ID-Hash: GMKHGDMXH5Y2R6PRGSLTPFFNBR54WRJ5 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 19, 2026 at 10:50 AM CEST, Fiona Ebner wrote: > Since the $noerr parameter was not passed along, the get_pkg > subroutine would log a failure when it couldn't determine the > installed package version for old kernel metapackages, e.g.: >> FAIL: unable to determine installed pve-kernel-6.5 version. > > Signed-off-by: Fiona Ebner > --- > PVE/CLI/pve8to9.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm > index 6512ff44..02d13f0e 100644 > --- a/PVE/CLI/pve8to9.pm > +++ b/PVE/CLI/pve8to9.pm > @@ -259,7 +259,7 @@ sub check_pve_packages { > my $outdated_kernel_meta_pkgs =3D []; > for my $kernel_meta_version ('6.2', '6.5', '6.8', '6.11') { > my $pkg =3D "pve-kernel-${kernel_meta_version}"; > - if ($get_pkg->($pkg)) { > + if ($get_pkg->($pkg, 1)) { > push @$outdated_kernel_meta_pkgs, $pkg; > } > } lgtm and also work for me, so consider this: Tested-by: Shannon Sterz Reviewed-by: Shannon Sterz