public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings
Date: Wed, 20 May 2026 16:20:13 +0200	[thread overview]
Message-ID: <yteurrdmxulnmqrjzzf6bgdb7rlwmq4kao375wa76kk7kowxso@isc4vowifbxb> (raw)
In-Reply-To: <1226cfe8-f171-42eb-b9b8-3b46beb8659d@proxmox.com>

On 20.05.2026 16:05, Thomas Lamprecht wrote:
> Am 20.05.26 um 16:00 schrieb Thomas Lamprecht:
> >> -                cbind: {
> >> -                    disabled: '{!isCreate}',
> >> -                    deleteEmpty: '{!isCreate}',
> >> -                },
> >> +                deleteEmpty: '{!isCreate}',
> > using that template syntax only makes sense inside a bind (viewModel) or
> > cbind (config bind), but you move them out of there, so this is not basically
> > a literal string. Should be rather changed to a literal true or false or
> > just dropped
> > 
> >>              });
> >>          }
> >>  
> >> @@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
> >>                      name: 'ip6_prefix',
> >>                      allowBlank: true,
> >>                      skipEmptyText: true,
> >> -                    cbind: {
> >> -                        disabled: '{!isCreate}',
> >> -                        deleteEmpty: '{!isCreate}',
> >> -                    },
> >> +                    deleteEmpty: '{!isCreate}',
> > same here
> 
> ah, I think you wanted to just drop the "disabled: '{!isCreate}'," line?

Nah, I actually wanted

	deleteEmtpy: !me.isCreate,

(without the cbind)

-_-

I'll send a new version




  reply	other threads:[~2026-05-20 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:51 [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support Gabriel Goller
2026-05-20 12:57   ` Dominik Csapak
2026-05-20 13:02     ` Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: validate prefixes as CIDR addresses Gabriel Goller
2026-05-20 13:35 ` [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Thomas Lamprecht
2026-05-20 13:43   ` Gabriel Goller
2026-05-20 14:00 ` Thomas Lamprecht
2026-05-20 14:05   ` Thomas Lamprecht
2026-05-20 14:20     ` Gabriel Goller [this message]
2026-05-20 14:14 ` applied: " Thomas Lamprecht
2026-05-20 14:23   ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yteurrdmxulnmqrjzzf6bgdb7rlwmq4kao375wa76kk7kowxso@isc4vowifbxb \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal