public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support
Date: Wed, 20 May 2026 14:57:52 +0200	[thread overview]
Message-ID: <2c64560f-5926-4598-a13f-b9a990537491@proxmox.com> (raw)
In-Reply-To: <20260520125125.251655-2-g.goller@proxmox.com>

because i just looked at this while trying to make a similar change:

is the reverse not also possible? so ipv6-only fabrics?

i noticed that when i add a fabric i have to enter *either* a
ipv4 or ipv6 address, but the subsequent node edit windows always
show both (even thouh i didn't configure an ipv4 address)

not sure if that makes sense?

On 5/20/26 2:51 PM, Gabriel Goller wrote:
> For fabricrs that only support IPv4, the IPv4 prefix is the only
> available prefix field. Mark it as mandatory in that case while keeping
> it optional for fabric types that also support IPv6.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>   www/manager6/sdn/fabrics/FabricEdit.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
> index 1f7bab362075..760925c50b95 100644
> --- a/www/manager6/sdn/fabrics/FabricEdit.js
> +++ b/www/manager6/sdn/fabrics/FabricEdit.js
> @@ -60,7 +60,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>                   fieldLabel: gettext('IPv4 Prefix'),
>                   labelWidth: 120,
>                   name: 'ip_prefix',
> -                allowBlank: true,
> +                allowBlank: me.hasIpv6Support,
>                   skipEmptyText: true,
>                   deleteEmpty: '{!isCreate}',
>               });





  reply	other threads:[~2026-05-20 12:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:51 [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support Gabriel Goller
2026-05-20 12:57   ` Dominik Csapak [this message]
2026-05-20 13:02     ` Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: validate prefixes as CIDR addresses Gabriel Goller
2026-05-20 13:35 ` [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Thomas Lamprecht
2026-05-20 13:43   ` Gabriel Goller
2026-05-20 14:00 ` Thomas Lamprecht
2026-05-20 14:05   ` Thomas Lamprecht
2026-05-20 14:20     ` Gabriel Goller
2026-05-20 14:14 ` applied: " Thomas Lamprecht
2026-05-20 14:23   ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c64560f-5926-4598-a13f-b9a990537491@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal