public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: applied: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings
Date: Wed, 20 May 2026 16:14:19 +0200	[thread overview]
Message-ID: <177928645744.422707.5013508994250906952.b4-ty@b4> (raw)
In-Reply-To: <20260520125125.251655-1-g.goller@proxmox.com>

On Wed, 20 May 2026 14:51:16 +0200, Gabriel Goller wrote:
> The prefix fields used an invalid cbind setup for their disabled state,
> so the bindings didn't work and editing the fabric prefix was possible.
> 
> Initially we didn't want the user to be able to update the prefix of a
> fabric, because we would need to add a mechanism to update all the node
> ips at the same time. This broke though and they became editable --
> which is fine, since you still get an error "node has ip out of prefix".
> Keep it this way, because editing a fabric without nodes is still
> useful.
> 
> [...]

Applied, with s/'{!isCreate}'/!me.isCreate/ fix-up, thanks!

[manager]
[1/1] ui: sdn: fabrics: drop dead disabled bindings
      commit: 4c424bf4f5a6549ae50162242e96d1a148cacb57
[1/1] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support
      commit: 8bf5b298010a6cf65bcbe5430bc820be7e0f1ecd
[1/1] ui: sdn: fabrics: validate prefixes as CIDR addresses
      commit: 5e2250fb98ba10a7d5b93db9b80fccbc69c492b2




  parent reply	other threads:[~2026-05-20 14:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:51 [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: require IPv4 prefix on fabrics without IPv6 support Gabriel Goller
2026-05-20 12:57   ` Dominik Csapak
2026-05-20 13:02     ` Gabriel Goller
2026-05-20 12:51 ` [PATCH manager] ui: sdn: fabrics: validate prefixes as CIDR addresses Gabriel Goller
2026-05-20 13:35 ` [PATCH network] ui: sdn: fabrics: drop dead disabled bindings Thomas Lamprecht
2026-05-20 13:43   ` Gabriel Goller
2026-05-20 14:00 ` Thomas Lamprecht
2026-05-20 14:05   ` Thomas Lamprecht
2026-05-20 14:20     ` Gabriel Goller
2026-05-20 14:14 ` Thomas Lamprecht [this message]
2026-05-20 14:23   ` applied: " Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177928645744.422707.5013508994250906952.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal