From: Gabriel Goller <g.goller@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps
Date: Mon, 18 May 2026 14:56:06 +0200 [thread overview]
Message-ID: <uekuodz2bo53phrpiac6rl4chkacwce5jajc6ufcykppgtkcfl@poiul6hioi4o> (raw)
In-Reply-To: <DILTEATNJ79Q.4AM5Q6I7ILFP@proxmox.com>
On 18.05.2026 14:51, Shannon Sterz wrote:
> On Mon May 18, 2026 at 2:37 PM CEST, Gabriel Goller wrote:
> > Teeniest tiniest nit: we should consistenly either capitalize or lowecase the
> > name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".)
>
> capitalizing both is not what the frr docs do [1], nor do i think that
> "prefix list is a proper noun. so standard english capitalization rules
> should apply -> prefix list. with "prefix" being capitalized at the
> beginning of sentences and both being capitalized when using title case
> [2].
>
> since this is pre-existing and, i'd argue, unrelated, i'll send a
> separate patch for this instead of a v2, if that's ok with you.
sounds good!
> [1]: https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
> [2]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Titles_and_Headlines
>
> >
> > Otherwise:
> > Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
>
> thanks!
>
next prev parent reply other threads:[~2026-05-18 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:16 [PATCH manager 0/2] add translation notes for prefix lists and route maps Shannon Sterz
2026-05-18 12:16 ` [PATCH manager 1/2] ui: add translation notes for prefix lists Shannon Sterz
2026-05-18 13:13 ` Shannon Sterz
2026-05-18 12:16 ` [PATCH manager 2/2] ui: add translation notes for route maps Shannon Sterz
2026-05-18 12:37 ` [PATCH manager 0/2] add translation notes for prefix lists and " Gabriel Goller
2026-05-18 12:51 ` Shannon Sterz
2026-05-18 12:56 ` Gabriel Goller [this message]
2026-05-18 13:32 ` Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uekuodz2bo53phrpiac6rl4chkacwce5jajc6ufcykppgtkcfl@poiul6hioi4o \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox