public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps
Date: Mon, 18 May 2026 14:37:31 +0200	[thread overview]
Message-ID: <a34tfvw63o7pwokqz73qstmyezk7dcxp2bewoimiyxsjkja7nf@7qhlnmoircp2> (raw)
In-Reply-To: <20260518121625.247708-1-s.sterz@proxmox.com>

Teeniest tiniest nit: we should consistenly either capitalize or lowecase the
name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".)

Otherwise:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>




  parent reply	other threads:[~2026-05-18 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 12:16 [PATCH manager 0/2] add translation notes for prefix lists and route maps Shannon Sterz
2026-05-18 12:16 ` [PATCH manager 1/2] ui: add translation notes for prefix lists Shannon Sterz
2026-05-18 13:13   ` Shannon Sterz
2026-05-18 12:16 ` [PATCH manager 2/2] ui: add translation notes for route maps Shannon Sterz
2026-05-18 12:37 ` Gabriel Goller [this message]
2026-05-18 12:51   ` [PATCH manager 0/2] add translation notes for prefix lists and " Shannon Sterz
2026-05-18 12:56     ` Gabriel Goller
2026-05-18 13:32 ` Superseded: " Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a34tfvw63o7pwokqz73qstmyezk7dcxp2bewoimiyxsjkja7nf@7qhlnmoircp2 \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal