Re: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> Nicolas Frey <n.frey@proxmox.com> writes:
>
>
>> This series fixes #7801 by implementing backend-only checks for VirtIO
>> ISOs with known issues. When a user starts, creates, or updates a VM,
>> the system scans for problematic VirtIO filenames and logs a warning in
>> the task log if a known issue is detected.
>>
>> This approach supersedes the earlier UI patches [0], following feedback
>> to implement the check in the backend. Since the backend check already
>> alerts users via task log warnings (an equally effective and less intrusive
>> solution) the separate API call and UI patches became unnecessary.
>>
>> Thanks Dominik and Maximilano for the feedback on the last revision
>>
>> [0] https://lore.proxmox.com/all/20260826074935.78437-1-n.frey@proxmox.com/
>
> Tested:
>
> - qm set 104 --ide0 local:iso/virtio-win-0.1.285.iso,media=cdrom
> - qm set 104 --ide1 local:iso/virtio-win-0.1.262.iso,media=cdrom
> - qm start 104
>
> the CLI produces 2 warnings as described in the commits.
>
> Note that the setting the ISOs in the UI won't produce a warnings and
> since there is no task, there will not be any visible issue. However,
> having warnings on qmstart is good enough in my opinion.
>
> Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

Modulo cosmetic things, the series looks good to me.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano