public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: Nicolas Frey <n.frey@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs
Date: Thu, 17 Sep 2026 15:17:12 +0200	[thread overview]
Message-ID: <972f0af5-cab7-4e30-bbed-893f2729d4a8@proxmox.com> (raw)
In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com>

On 9/15/26 16:32, Nicolas Frey wrote:
> This series fixes #7801 by implementing backend-only checks for VirtIO
> ISOs with known issues. When a user starts, creates, or updates a VM,
> the system scans for problematic VirtIO filenames and logs a warning in
> the task log if a known issue is detected.
>
> This approach supersedes the earlier UI patches [0], following feedback
> to implement the check in the backend. Since the backend check already
> alerts users via task log warnings (an equally effective and less intrusive
> solution) the separate API call and UI patches became unnecessary.
>
> Thanks Dominik and Maximilano for the feedback on the last revision
>
> [0] https://lore.proxmox.com/all/20260826074935.78437-1-n.frey@proxmox.com/
>
> <snip>

Tested the patches on current qemu-server v9.2.9.

Works as intended.
Only workflow that feels a little bit weird to me is when creating
a Windows VM with an affected ISO version and using "Start after Create"
This causes two directly consecutive tasks with warnings but i also
do not have a better idea on how to avoid this.

Tested (Web UI):
  * Existing Windows VM with affected ISO => Warning
  * Existing Windows VM with unaffected ISO => No Warning
  * New VM with affected ISO => Warning on create and start

Tested-by: Jonas Theisen <j.theisen@proxmox.com>




      parent reply	other threads:[~2026-09-17 13:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 14:32 [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs Nicolas Frey
2026-09-15 14:32 ` [PATCH qemu-server 1/3] drive: add helper to detect VirtIO driver ISOs with known issues Nicolas Frey
2026-09-16 10:16   ` Maximiliano Sandoval
2026-09-16 10:23   ` Maximiliano Sandoval
2026-09-15 14:32 ` [PATCH qemu-server 2/3] partially fix #7801: api: warn about problematic VirtIO driver ISOs Nicolas Frey
2026-09-15 14:32 ` [PATCH qemu-server 3/3] partially fix #7801: vm start: warn about problematic VirtIO ISOs Nicolas Frey
2026-09-16 10:21 ` [PATCH qemu-server 0/3] fix #7801: " Maximiliano Sandoval
2026-09-16 10:26   ` Maximiliano Sandoval
2026-09-17 13:17 ` Jonas Theisen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=972f0af5-cab7-4e30-bbed-893f2729d4a8@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal