From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DDCE71FF0A7 for ; Wed, 16 Sep 2026 12:26:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 75562214A3; Wed, 16 Sep 2026 12:26:57 +0200 (CEST) From: Maximiliano Sandoval To: Nicolas Frey Subject: Re: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs In-Reply-To: (Maximiliano Sandoval's message of "Wed, 16 Sep 2026 12:21:33 +0200") References: <20260915143237.1033142-1-n.frey@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 16 Sep 2026 12:26:52 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789554412292 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.811 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QGNVX2JMBI5BTZFY5DOIK5UJYMRVG7FP X-Message-ID-Hash: QGNVX2JMBI5BTZFY5DOIK5UJYMRVG7FP X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Maximiliano Sandoval writes: > Nicolas Frey writes: > > >> This series fixes #7801 by implementing backend-only checks for VirtIO >> ISOs with known issues. When a user starts, creates, or updates a VM, >> the system scans for problematic VirtIO filenames and logs a warning in >> the task log if a known issue is detected. >> >> This approach supersedes the earlier UI patches [0], following feedback >> to implement the check in the backend. Since the backend check already >> alerts users via task log warnings (an equally effective and less intrusive >> solution) the separate API call and UI patches became unnecessary. >> >> Thanks Dominik and Maximilano for the feedback on the last revision >> >> [0] https://lore.proxmox.com/all/20260826074935.78437-1-n.frey@proxmox.com/ > > Tested: > > - qm set 104 --ide0 local:iso/virtio-win-0.1.285.iso,media=cdrom > - qm set 104 --ide1 local:iso/virtio-win-0.1.262.iso,media=cdrom > - qm start 104 > > the CLI produces 2 warnings as described in the commits. > > Note that the setting the ISOs in the UI won't produce a warnings and > since there is no task, there will not be any visible issue. However, > having warnings on qmstart is good enough in my opinion. > > Tested-by: Maximiliano Sandoval Modulo cosmetic things, the series looks good to me. Reviewed-by: Maximiliano Sandoval -- Maximiliano