public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH kronosnet] d/build: Re-enable sctp when building libknet
@ 2026-09-07  8:46 Maximiliano Sandoval
  2026-09-07  8:51 ` Abobakr Mohammed
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2026-09-07  8:46 UTC (permalink / raw)
  To: pve-devel

scpt was disabled by default in 1.32 [1]. We enable it back to avoid breaking
setups using sctp during a upgrade.

This should be removed for the next major release and added to the upgrade
helper script.

[1] https://github.com/kronosnet/kronosnet/releases/tag/v1.32

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 2c28cb5..5f244a5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,12 +10,14 @@ export DEB_LDFLAGS_MAINT_APPEND=-Wl,-z,defs
 %:
 	dh $@
 
+# FIXME: MAJOR VERSION: Remove the SCTP option for pve 10
 override_dh_auto_configure:
 	dh_auto_configure -- \
 		--docdir=/usr/share/doc/libknet1 \
 		`dh_listpackages | grep -q '^libknet-doc$$' || printf %s --disable-man` \
 		--disable-static \
 		--disable-wireshark-dissector \
+		--enable-libknet-sctp \
 		;
 
 override_dh_installdocs:
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH kronosnet] d/build: Re-enable sctp when building libknet
  2026-09-07  8:46 [PATCH kronosnet] d/build: Re-enable sctp when building libknet Maximiliano Sandoval
@ 2026-09-07  8:51 ` Abobakr Mohammed
  0 siblings, 0 replies; 2+ messages in thread
From: Abobakr Mohammed @ 2026-09-07  8:51 UTC (permalink / raw)
  To: Maximiliano Sandoval; +Cc: pve-devel

LGTM.
Tested​-by: Abobakr Mohammed <a.mohammed@proxmox.com>
On Monday, 09/07/2026, 10:46, Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

From : Maximiliano Sandoval <m.sandoval@proxmox.com>
Sent on : Monday, 09/07/2026, 10:46
To : pve-devel@lists.proxmox.com
Subject : [PATCH kronosnet] d/build: Re-enable sctp when building libknet
scpt was disabled by default in 1.32 [1]. We enable it back to avoid breaking
setups using sctp during a upgrade.

This should be removed for the next major release and added to the upgrade
helper script.

[1] https://github.com/kronosnet/kronosnet/releases/tag/v1.32

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 2c28cb5..5f244a5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,12 +10,14 @@ export DEB_LDFLAGS_MAINT_APPEND=-Wl,-z,defs
 %:
 	dh $@
 
+# FIXME: MAJOR VERSION: Remove the SCTP option for pve 10
 override_dh_auto_configure:
 	dh_auto_configure -- \
 		--docdir=/usr/share/doc/libknet1 \
 		`dh_listpackages | grep -q '^libknet-doc$$' || printf %s --disable-man` \
 		--disable-static \
 		--disable-wireshark-dissector \
+		--enable-libknet-sctp \
 		;
 
 override_dh_installdocs:
-- 
2.47.3







^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-07  8:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-07  8:46 [PATCH kronosnet] d/build: Re-enable sctp when building libknet Maximiliano Sandoval
2026-09-07  8:51 ` Abobakr Mohammed

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal