From: Abobakr Mohammed <a.mohammed@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH kronosnet] d/build: Re-enable sctp when building libknet
Date: Mon, 7 Sep 2026 08:51:30 +0000 [thread overview]
Message-ID: <mtr00jd0.1o3pcoiafuk1s@proxmox.com> (raw)
In-Reply-To: <20260907084603.245287-1-m.sandoval@proxmox.com>
LGTM.
Tested-by: Abobakr Mohammed <a.mohammed@proxmox.com>
On Monday, 09/07/2026, 10:46, Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
From : Maximiliano Sandoval <m.sandoval@proxmox.com>
Sent on : Monday, 09/07/2026, 10:46
To : pve-devel@lists.proxmox.com
Subject : [PATCH kronosnet] d/build: Re-enable sctp when building libknet
scpt was disabled by default in 1.32 [1]. We enable it back to avoid breaking
setups using sctp during a upgrade.
This should be removed for the next major release and added to the upgrade
helper script.
[1] https://github.com/kronosnet/kronosnet/releases/tag/v1.32
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
debian/rules | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/rules b/debian/rules
index 2c28cb5..5f244a5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,12 +10,14 @@ export DEB_LDFLAGS_MAINT_APPEND=-Wl,-z,defs
%:
dh $@
+# FIXME: MAJOR VERSION: Remove the SCTP option for pve 10
override_dh_auto_configure:
dh_auto_configure -- \
--docdir=/usr/share/doc/libknet1 \
`dh_listpackages | grep -q '^libknet-doc$$' || printf %s --disable-man` \
--disable-static \
--disable-wireshark-dissector \
+ --enable-libknet-sctp \
;
override_dh_installdocs:
--
2.47.3
prev parent reply other threads:[~2026-09-07 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 8:46 [PATCH kronosnet] d/build: Re-enable sctp when building libknet Maximiliano Sandoval
2026-09-07 8:51 ` Abobakr Mohammed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mtr00jd0.1o3pcoiafuk1s@proxmox.com \
--to=a.mohammed@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox