Re: [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons

[Gabriel Goller <g.goller@proxmox.com>]

On 19.05.2026 11:25, Hannes Laimer wrote:
> Every sdn-apply on a node that has a BGP fabric configured trips the
> set_daemon_status() guard with "bgpd is not SDN managed", aborting FRR
> config generation. The Rust enabled_daemons() reports bgpd for BGP
> fabrics, but the Perl allowlist was only updated for OSPF and OpenFabric
> when those fabric types were originally added.
> 
> Default bgpd to enabled, unlike ospfd and fabricd: the BGP and EVPN
> controllers also depend on bgpd and do not manage /etc/frr/daemons
> themselves, so removing the last BGP fabric must not silently disable
> bgpd on a system where a controller still needs it.
> 
> Fixes: 9d8533d ("sdn: fabrics: register bgp as a fabric protocol type")
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>

Gave it a quick spin, should be alright:

Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

> ---
> v2, thanks @Gabriel:
>  - default to 1, other controllers that don't manage deamons depend on
>    it
> 
>  src/PVE/Network/SDN/Frr.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm
> index 7c60d28..f81da32 100644
> --- a/src/PVE/Network/SDN/Frr.pm
> +++ b/src/PVE/Network/SDN/Frr.pm
> @@ -125,6 +125,7 @@ sub restart {
>  my $SDN_DAEMONS_DEFAULT = {
>      ospfd => 0,
>      fabricd => 0,
> +    bgpd => 1,
>  };
>  
>  =head3 set_daemon_status(\%daemons, $set_default)
> -- 
> 2.47.3