public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons
Date: Tue, 19 May 2026 11:25:37 +0200	[thread overview]
Message-ID: <20260519092537.19326-1-h.laimer@proxmox.com> (raw)

Every sdn-apply on a node that has a BGP fabric configured trips the
set_daemon_status() guard with "bgpd is not SDN managed", aborting FRR
config generation. The Rust enabled_daemons() reports bgpd for BGP
fabrics, but the Perl allowlist was only updated for OSPF and OpenFabric
when those fabric types were originally added.

Default bgpd to enabled, unlike ospfd and fabricd: the BGP and EVPN
controllers also depend on bgpd and do not manage /etc/frr/daemons
themselves, so removing the last BGP fabric must not silently disable
bgpd on a system where a controller still needs it.

Fixes: 9d8533d ("sdn: fabrics: register bgp as a fabric protocol type")
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
v2, thanks @Gabriel:
 - default to 1, other controllers that don't manage deamons depend on
   it

 src/PVE/Network/SDN/Frr.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm
index 7c60d28..f81da32 100644
--- a/src/PVE/Network/SDN/Frr.pm
+++ b/src/PVE/Network/SDN/Frr.pm
@@ -125,6 +125,7 @@ sub restart {
 my $SDN_DAEMONS_DEFAULT = {
     ospfd => 0,
     fabricd => 0,
+    bgpd => 1,
 };
 
 =head3 set_daemon_status(\%daemons, $set_default)
-- 
2.47.3





             reply	other threads:[~2026-05-19  9:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  9:25 Hannes Laimer [this message]
2026-05-19 10:45 ` [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519092537.19326-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal