From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1613C1FF141 for ; Tue, 19 May 2026 11:25:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7FB036F54; Tue, 19 May 2026 11:25:42 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons Date: Tue, 19 May 2026 11:25:37 +0200 Message-ID: <20260519092537.19326-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779182725111 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PYINQ3ZQ2NGHHCF5YQFSNR7GWSBGSYWM X-Message-ID-Hash: PYINQ3ZQ2NGHHCF5YQFSNR7GWSBGSYWM X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Every sdn-apply on a node that has a BGP fabric configured trips the set_daemon_status() guard with "bgpd is not SDN managed", aborting FRR config generation. The Rust enabled_daemons() reports bgpd for BGP fabrics, but the Perl allowlist was only updated for OSPF and OpenFabric when those fabric types were originally added. Default bgpd to enabled, unlike ospfd and fabricd: the BGP and EVPN controllers also depend on bgpd and do not manage /etc/frr/daemons themselves, so removing the last BGP fabric must not silently disable bgpd on a system where a controller still needs it. Fixes: 9d8533d ("sdn: fabrics: register bgp as a fabric protocol type") Signed-off-by: Hannes Laimer --- v2, thanks @Gabriel: - default to 1, other controllers that don't manage deamons depend on it src/PVE/Network/SDN/Frr.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm index 7c60d28..f81da32 100644 --- a/src/PVE/Network/SDN/Frr.pm +++ b/src/PVE/Network/SDN/Frr.pm @@ -125,6 +125,7 @@ sub restart { my $SDN_DAEMONS_DEFAULT = { ospfd => 0, fabricd => 0, + bgpd => 1, }; =head3 set_daemon_status(\%daemons, $set_default) -- 2.47.3