From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 392C21FF141 for ; Tue, 19 May 2026 12:46:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7516916D5; Tue, 19 May 2026 12:46:16 +0200 (CEST) Date: Tue, 19 May 2026 12:45:42 +0200 From: Gabriel Goller To: Hannes Laimer Subject: Re: [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons Message-ID: Mail-Followup-To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260519092537.19326-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260519092537.19326-1-h.laimer@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779187528833 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LZQYJQFNKUIOK4ITLUR7RWIX3EAZKHWS X-Message-ID-Hash: LZQYJQFNKUIOK4ITLUR7RWIX3EAZKHWS X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 19.05.2026 11:25, Hannes Laimer wrote: > Every sdn-apply on a node that has a BGP fabric configured trips the > set_daemon_status() guard with "bgpd is not SDN managed", aborting FRR > config generation. The Rust enabled_daemons() reports bgpd for BGP > fabrics, but the Perl allowlist was only updated for OSPF and OpenFabric > when those fabric types were originally added. > > Default bgpd to enabled, unlike ospfd and fabricd: the BGP and EVPN > controllers also depend on bgpd and do not manage /etc/frr/daemons > themselves, so removing the last BGP fabric must not silently disable > bgpd on a system where a controller still needs it. > > Fixes: 9d8533d ("sdn: fabrics: register bgp as a fabric protocol type") > Signed-off-by: Hannes Laimer Gave it a quick spin, should be alright: Reviewed-by: Gabriel Goller > --- > v2, thanks @Gabriel: > - default to 1, other controllers that don't manage deamons depend on > it > > src/PVE/Network/SDN/Frr.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm > index 7c60d28..f81da32 100644 > --- a/src/PVE/Network/SDN/Frr.pm > +++ b/src/PVE/Network/SDN/Frr.pm > @@ -125,6 +125,7 @@ sub restart { > my $SDN_DAEMONS_DEFAULT = { > ospfd => 0, > fabricd => 0, > + bgpd => 1, > }; > > =head3 set_daemon_status(\%daemons, $set_default) > -- > 2.47.3