Re: [PATCH qemu-server 1/2] test: mock query-version qmp command

[Fiona Ebner <f.ebner@proxmox.com>]

Am 24.06.26 um 10:41 AM schrieb Maximiliano Sandoval:
> In the next commit we add a call to query-version to log the package
> version when starting a VM.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/test/MigrationTest/QmMock.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/test/MigrationTest/QmMock.pm b/src/test/MigrationTest/QmMock.pm
> index 311dbb39..fa5c9989 100644
> --- a/src/test/MigrationTest/QmMock.pm
> +++ b/src/test/MigrationTest/QmMock.pm
> @@ -54,6 +54,8 @@ my sub mocked_mon_cmd {
>          return [];
>      } elsif ($command eq 'qom-set') {
>          return;
> +    } elsif ($command eq 'query-version') {
> +        return;

Please return an actual (dummy) result as the command would, to make the
testing more realistic.

>      }
>      die "mon_cmd (mocked) - implement me: $command";
>  }

Please use a cover letter when you send more than one patch. This makes
using tools like b4 easier.