Re: [PATCH qemu-server 2/2] vm start: log qemu version when starting a VM

[Fiona Ebner <f.ebner@proxmox.com>]

Am 24.06.26 um 10:42 AM schrieb Maximiliano Sandoval:
> Previously, having the system journal and task logs from a boot was not
> enough to determine which qemu version is installed nor the running QEMU
> version of a VM. This is addressed by logging pve-qemu-kvm's package
> version when starting the VM.
> 
> The package version is obtained with the 'query-version' qmp command.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Notes:
>     sample output in the journal:
>     
>     Jun 24 10:39:14 pve-148 qm[26137]: VM 100 started with PID 26166 using pve-qemu-kvm_11.0.0-4.
> 
>  src/PVE/QemuServer.pm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 55e9f520..d6576a41 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -5839,7 +5839,8 @@ sub vm_start_nolock {
>      eval { PVE::QemuServer::PCI::reserve_pci_usage($pci_reserve_list, $vmid, undef, $pid) };
>      warn $@ if $@;
>  
> -    syslog("info", "VM $vmid started with PID $pid.");
> +    my $pgk_version = get_package_version($vmid);

Typo: pgk

> +    syslog("info", "VM $vmid started with PID $pid using $pgk_version.");
>  
>      PVE::QemuServer::RunState::create_cleanup_flag($vmid);
>  
> @@ -8054,6 +8055,12 @@ sub get_running_qemu_version {
>      return "$res->{qemu}->{major}.$res->{qemu}->{minor}";
>  }
>  
> +sub get_package_version {

This should live in QMPHelpers.pm. Then it's automatically clear that it
is queried via QMP when you're reading the code of a call site. Also,
maybe get_qemu_package_version() to be even more explicit.

> +    my ($vmid) = @_;
> +    my $res = mon_cmd($vmid, "query-version");
> +    return $res->{package};
> +}
> +
>  sub qemu_use_old_bios_files {
>      my ($machine_type) = @_;
>