From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6BEB01FF138 for ; Mon, 29 Jun 2026 16:12:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 35B9021434; Mon, 29 Jun 2026 16:12:39 +0200 (CEST) Message-ID: Date: Mon, 29 Jun 2026 16:12:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server 1/2] test: mock query-version qmp command To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260624084201.168436-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260624084201.168436-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782742314719 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E2QEXGKUKOCZEN2IJJW5AUYJKEVTFICQ X-Message-ID-Hash: E2QEXGKUKOCZEN2IJJW5AUYJKEVTFICQ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 24.06.26 um 10:41 AM schrieb Maximiliano Sandoval: > In the next commit we add a call to query-version to log the package > version when starting a VM. > > Signed-off-by: Maximiliano Sandoval > --- > src/test/MigrationTest/QmMock.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/test/MigrationTest/QmMock.pm b/src/test/MigrationTest/QmMock.pm > index 311dbb39..fa5c9989 100644 > --- a/src/test/MigrationTest/QmMock.pm > +++ b/src/test/MigrationTest/QmMock.pm > @@ -54,6 +54,8 @@ my sub mocked_mon_cmd { > return []; > } elsif ($command eq 'qom-set') { > return; > + } elsif ($command eq 'query-version') { > + return; Please return an actual (dummy) result as the command would, to make the testing more realistic. > } > die "mon_cmd (mocked) - implement me: $command"; > } Please use a cover letter when you send more than one patch. This makes using tools like b4 easier.