public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server 1/3] qemuserver: add pvpanic device
Date: Tue, 8 Sep 2026 18:09:01 +0800	[thread overview]
Message-ID: <f31ed5bf-60f3-44ab-906d-73df0a9818d2@gmail.com> (raw)
In-Reply-To: <80d7911d-77d5-40aa-af27-a0bac993858c@proxmox.com>

On 2026-09-04 16:30, Dominik Csapak wrote:
>> +        optional => 1,
>> +        type => 'string',
>> +        description => "Configure a pvpanic device to monitor guest 
>> panics",
>> +        enum => [qw(pvpanic pvpanic-pci)],
> 
> is it really useful to have two variants? couldn't we always
> use the PCI variant or is there some specific usecase for the ISA one?
> 
> It could even be simply an option somewhere else (e.g. on the machine 
> maybe?)
> 
> if we just have single option, this might simplify the code below...
> 

An use case for this is deploying the ISA variant on Linux VMs with 
kernel version >=3.1 and <5.2. The PCI variant is not supported until 
Linux 5.2.

We could not use the ISA variant by default either, since QEMU does not 
support ISA devices at all on ARM64.



  reply	other threads:[~2026-09-08 10:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 10:35 [PATCH qemu-server/docs/manager 0/3] add pvpanic device support Kaiyang Wu
2026-08-27 10:35 ` [PATCH qemu-server 1/3] qemuserver: add pvpanic device Kaiyang Wu
2026-09-04  8:30   ` Dominik Csapak
2026-09-08 10:09     ` Kaiyang Wu [this message]
2026-09-08 11:05       ` Dominik Csapak
2026-08-27 10:35 ` [PATCH docs 2/3] qm: add document section for the " Kaiyang Wu
2026-08-27 10:35 ` [PATCH manager 3/3] ui: qemu: add pvpanic device support Kaiyang Wu
2026-09-04  8:30   ` Dominik Csapak
2026-09-03  8:42 ` [PATCH qemu-server/docs/manager 0/3] " Kaiyang Wu
2026-09-04  8:30 ` Dominik Csapak
2026-09-08 10:18   ` Kaiyang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f31ed5bf-60f3-44ab-906d-73df0a9818d2@gmail.com \
    --to=wukaiyang2003@gmail.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal