From: Dominik Csapak <d.csapak@proxmox.com>
To: Kaiyang Wu <wukaiyang2003@gmail.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server/docs/manager 0/3] add pvpanic device support
Date: Fri, 4 Sep 2026 10:30:02 +0200 [thread overview]
Message-ID: <cabe98d8-d7ed-4590-8d60-ebb909ad19ff@proxmox.com> (raw)
In-Reply-To: <20260827103529.393388-1-wukaiyang@loongfans.cn>
Hi,
high level question:
with this series, the pvpanic device is added, but nothing on the other
side queries it? So what's the use case here?
I think it could come in handy, but we should actually do something with
it ;)
E.g. at least we could also set the panic handler in tandem:
--action panic=none|shutdown|...
e.g. a shutdown action on panic paired with our HA stack could
reboot the vm (didn't test though)
On 8/27/26 12:35 PM, Kaiyang Wu wrote:
> This patchset adds pvpanic device support to QEMU virtual machines to
> provide extra virtual machine status (guest-panicked) when virtual
> machines panic.
>
> The pvpanic device can be implemented as an ISA device ('-device
> pvpanic') or as a PCI device ('-device pvpanic-pci') [0]. The ISA
> pvpanic device is only available on x86_64, and Linux VMs with kernel
>> =3.1 and <5.2 only support the ISA pvpanic device [1] [2]. Therefore,
> the patchset allows to choose between the two variants to fit different
> needs, and adds a documentation section to help picking the variant.
>
> [0]: https://www.qemu.org/docs/master/specs/pvpanic.html
> [1]: https://www.kernelconfig.io/CONFIG_PVPANIC
> [2]: https://www.kernelconfig.io/CONFIG_PVPANIC_PCI
>
>
> qemu-server:
>
> Kaiyang Wu (1):
> qemuserver: add pvpanic device
>
> src/PVE/API2/Qemu.pm | 1 +
> src/PVE/QemuServer.pm | 19 +++++++++++++++++++
> src/PVE/QemuServer/PCI.pm | 1 +
> 3 files changed, 21 insertions(+)
>
>
> docs:
>
> Kaiyang Wu (1):
> qm: add document section for the pvpanic device
>
> qm.adoc | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
>
> manager:
>
> Kaiyang Wu (1):
> ui: qemu: add pvpanic device support
>
> www/manager6/Makefile | 2 ++
> www/manager6/Utils.js | 1 +
> www/manager6/form/PvpanicSelector.js | 12 +++++++++
> www/manager6/qemu/Architecture.js | 5 ++++
> www/manager6/qemu/HardwareView.js | 15 +++++++++++
> www/manager6/qemu/PvpanicEdit.js | 39 ++++++++++++++++++++++++++++
> 6 files changed, 74 insertions(+)
> create mode 100644 www/manager6/form/PvpanicSelector.js
> create mode 100644 www/manager6/qemu/PvpanicEdit.js
>
prev parent reply other threads:[~2026-09-04 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 10:35 [PATCH qemu-server/docs/manager 0/3] add pvpanic device support Kaiyang Wu
2026-08-27 10:35 ` [PATCH qemu-server 1/3] qemuserver: add pvpanic device Kaiyang Wu
2026-09-04 8:30 ` Dominik Csapak
2026-08-27 10:35 ` [PATCH docs 2/3] qm: add document section for the " Kaiyang Wu
2026-08-27 10:35 ` [PATCH manager 3/3] ui: qemu: add pvpanic device support Kaiyang Wu
2026-09-04 8:30 ` Dominik Csapak
2026-09-03 8:42 ` [PATCH qemu-server/docs/manager 0/3] " Kaiyang Wu
2026-09-04 8:30 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cabe98d8-d7ed-4590-8d60-ebb909ad19ff@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=wukaiyang2003@gmail.com \
--cc=wukaiyang@loongfans.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox