From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7C31B1FF0A5 for ; Fri, 04 Sep 2026 10:30:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8325321553; Fri, 04 Sep 2026 10:30:08 +0200 (CEST) Message-ID: Date: Fri, 4 Sep 2026 10:30:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server/docs/manager 0/3] add pvpanic device support To: Kaiyang Wu , pve-devel@lists.proxmox.com References: <20260827103529.393388-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260827103529.393388-1-wukaiyang@loongfans.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788510599043 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.558 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: T42C4K3AYC5HMWLMKUP2LNAVPZGXL54L X-Message-ID-Hash: T42C4K3AYC5HMWLMKUP2LNAVPZGXL54L X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, high level question: with this series, the pvpanic device is added, but nothing on the other side queries it? So what's the use case here? I think it could come in handy, but we should actually do something with it ;) E.g. at least we could also set the panic handler in tandem: --action panic=none|shutdown|... e.g. a shutdown action on panic paired with our HA stack could reboot the vm (didn't test though) On 8/27/26 12:35 PM, Kaiyang Wu wrote: > This patchset adds pvpanic device support to QEMU virtual machines to > provide extra virtual machine status (guest-panicked) when virtual > machines panic. > > The pvpanic device can be implemented as an ISA device ('-device > pvpanic') or as a PCI device ('-device pvpanic-pci') [0]. The ISA > pvpanic device is only available on x86_64, and Linux VMs with kernel >> =3.1 and <5.2 only support the ISA pvpanic device [1] [2]. Therefore, > the patchset allows to choose between the two variants to fit different > needs, and adds a documentation section to help picking the variant. > > [0]: https://www.qemu.org/docs/master/specs/pvpanic.html > [1]: https://www.kernelconfig.io/CONFIG_PVPANIC > [2]: https://www.kernelconfig.io/CONFIG_PVPANIC_PCI > > > qemu-server: > > Kaiyang Wu (1): > qemuserver: add pvpanic device > > src/PVE/API2/Qemu.pm | 1 + > src/PVE/QemuServer.pm | 19 +++++++++++++++++++ > src/PVE/QemuServer/PCI.pm | 1 + > 3 files changed, 21 insertions(+) > > > docs: > > Kaiyang Wu (1): > qm: add document section for the pvpanic device > > qm.adoc | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > > manager: > > Kaiyang Wu (1): > ui: qemu: add pvpanic device support > > www/manager6/Makefile | 2 ++ > www/manager6/Utils.js | 1 + > www/manager6/form/PvpanicSelector.js | 12 +++++++++ > www/manager6/qemu/Architecture.js | 5 ++++ > www/manager6/qemu/HardwareView.js | 15 +++++++++++ > www/manager6/qemu/PvpanicEdit.js | 39 ++++++++++++++++++++++++++++ > 6 files changed, 74 insertions(+) > create mode 100644 www/manager6/form/PvpanicSelector.js > create mode 100644 www/manager6/qemu/PvpanicEdit.js >