From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 607451FF0B4 for ; Tue, 08 Sep 2026 12:09:23 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BBF0021507; Tue, 08 Sep 2026 12:09:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788862145; x=1789466945; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QKnnVpxIJ3Gu1BCSjNvjzUQTrTtor3kf9LNKOBXD3Rg=; b=ehBF0kClY4KBk/Fvomoa1F4rYrK2NeIJxK56uwy208cDYBZf26s6ydENSGJxb+85N2 Jkhn5eFl0C9Irecg/csHhdL9wH4dSJfQEy9cB3ud22PkoSJxwnZQqgaOMHZVD02lrl73 WjYqGrZIv+AbwGHBz6AUMWUFDoTl4nDFFtRJ/4kUPernRAL/Z7krQL+rGYeUeH4RA4BB Vv0L+qmtLvUWNRxM4Jq22zqJ6e7GCjBX1e8vpEzeKGPnaK99Ehsw+XDC13Nmhr2wghoq IsUnbfSfpCUA38uuXrPzqG3wAxfg5p0rJonN65QBWWkarc57/RxsLYnN9cJSzugftZXb Oyfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788862145; x=1789466945; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QKnnVpxIJ3Gu1BCSjNvjzUQTrTtor3kf9LNKOBXD3Rg=; b=ncVA1sNC2d7rUiK103wcTZkV2UCIDEW28RkSzliHFFH2MTeW+PTTDe5bDUyfmu3rXr w5CBuvsxDs95U0Z+P2i3oTHLPfigFyzMIShtr44EeVS3fxIhHv4K/I8ldIjtv0AQtUI7 bZfFTeJOkkwiEaCJ6P5JfUtH8dWn2trwAr1WHD8SgaGHJCsEHG17qGIE5i1S6sn/uufT yBXYvaLk4VFMiUIirAFYgI8rchGJAYr7fZHZgqV4F5JiEoyqaapTshIvd4PbtGdjW8pj /OE0sMUcax8hCV/U/FZ1OuhMds7BxROKkGYq8YoXDaPsqLLVXZbQrqTk/+YU6OTpCJhh cBqg== X-Forwarded-Encrypted: i=1; AKwUvBwKFJqy34+pyyfV41Z7xnmiZrRMt+4jL79DDQO4cW1CrgSfgBtKl9Gn9YawyG7HJWrdXxx/q/Tvnwo=@lists.proxmox.com X-Gm-Message-State: AFuF++lUAOoTgfQqMCPyxOUz77PfY2dlsQ7RWz5HQsgtDSf/rauxAa6B 93OYLD9LXQm8j4AZm7pgdBgPdQ8gyhmY/z9XzXdbCWT112QS/paNpdBBOBuqug== X-Gm-Gg: AYBFou3wUaiOtg2npUF+WttbJzANajH6bJNuMf2Gc3BOwmCCPkO5fWMY6htAQTrURDV G2YGH7HtRCr5vMF87XUVCEOiveUUwPn1xQUJWPeHKUlZbQmfwqgNM5X9VpG0reW0D/+RfKmK3q+ oRCbLmVubUNT69vqqSCnE6MpZrRhF6OFo1PJ62u73HiPBcjSlf4urhLsOMsb+YBw9xTeVoHfT49 Q/YBzZltbAVsyFKJy4cAxULhlSseXFuV8bzXkya8mpX9q98ezDE8vh17II2aP1awE8Y61DHePNa hJpaFtyDK25X+jlv0lGkywmLikpngH3nzXQBmg77tMZfnZWqYPEZgYpmZlHpYLBk+dvBPGNTN3V vS0uyn0wP7yVFK47MrHw/xTAo983Mxck9OHzUiVAClN+JNs3/Gni9hs+qZG25ozglqwEpCpw3+0 ytU+2rGfXAk6jsAPAr+ciRyT0VW9C/Bq+QaPbmD7YR+ClzSqrEYzVCYLj+rgEUhkIsDx1ajfI/ X-Received: by 2002:a17:90b:2f46:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39b260de5c6mr46089552a91.2.1788862144636; Tue, 08 Sep 2026 03:09:04 -0700 (PDT) Message-ID: Date: Tue, 8 Sep 2026 18:09:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server 1/3] qemuserver: add pvpanic device To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260827103529.393388-1-wukaiyang@loongfans.cn> <20260827103529.393388-2-wukaiyang@loongfans.cn> <80d7911d-77d5-40aa-af27-a0bac993858c@proxmox.com> Content-Language: en-US From: Kaiyang Wu In-Reply-To: <80d7911d-77d5-40aa-af27-a0bac993858c@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2HYMVL2KMLLRZYLZWNBPYS24UYAU3RAU X-Message-ID-Hash: 2HYMVL2KMLLRZYLZWNBPYS24UYAU3RAU X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-09-04 16:30, Dominik Csapak wrote: >> +        optional => 1, >> +        type => 'string', >> +        description => "Configure a pvpanic device to monitor guest >> panics", >> +        enum => [qw(pvpanic pvpanic-pci)], > > is it really useful to have two variants? couldn't we always > use the PCI variant or is there some specific usecase for the ISA one? > > It could even be simply an option somewhere else (e.g. on the machine > maybe?) > > if we just have single option, this might simplify the code below... > An use case for this is deploying the ISA variant on Linux VMs with kernel version >=3.1 and <5.2. The PCI variant is not supported until Linux 5.2. We could not use the ISA variant by default either, since QEMU does not support ISA devices at all on ARM64.