Re: [PATCH pve-access-control v5 3/7] test: add sdn acl pruning tests

[David Riley <d.riley@proxmox.com>]

On 7/16/26 9:33 AM, Daniel Kral wrote:
> On Tue Jul 7, 2026 at 2:04 PM CEST, David Riley wrote:
>> Add unit tests to validate the behavior of the SDN resource ACL
>> pruning logic.
>>
>> The tests cover all designated SDN resource paths including zones,
>> vnets (with/without tags), controllers, prefix-lists, route-maps, and
>> fabrics, ensuring explicit permissions are dropped when resources are
>> deleted.
>>
>> Signed-off-by: David Riley <d.riley@proxmox.com>
>> ---
>>   src/test/Makefile                |   1 +
>>   src/test/sdn_acl_pruning_test.pl | 134 +++++++++++++++++++++++++++++++
>>   2 files changed, 135 insertions(+)
>>   create mode 100644 src/test/sdn_acl_pruning_test.pl
>>
>> diff --git a/src/test/Makefile b/src/test/Makefile
>> index 53f2da7..2f44186 100644
>> --- a/src/test/Makefile
>> +++ b/src/test/Makefile
>> @@ -14,3 +14,4 @@ check:
>>   	perl -I.. perm-test8.pl
>>   	perl -I.. realm_sync_test.pl
>>   	perl -I.. api-tests.pl
>> +	perl -I.. sdn_acl_pruning_test.pl
>> diff --git a/src/test/sdn_acl_pruning_test.pl b/src/test/sdn_acl_pruning_test.pl
>> new file mode 100644
>> index 0000000..f407c89
>> --- /dev/null
>> +++ b/src/test/sdn_acl_pruning_test.pl
>> @@ -0,0 +1,134 @@
>> +#!/usr/bin/env perl
>> +
>> +use v5.36;
>> +use strict;
>> +use warnings;
> nit: sorry should have said that in my previous review, but 'use v5.36'
>       already implies the 'use strict' and 'use warnings', so the latter
>       two are not needed anymore
>
> same for the other test patch

Alright, thanks for the heads up.
No worries, I'll adapt it in v6.

>
>> +
>> +use lib qw(..);
>> +
> [ snip ]
>
>
>
>