From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 328F91FF0E9 for ; Thu, 16 Jul 2026 10:05:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0EBDC213F2; Thu, 16 Jul 2026 10:05:18 +0200 (CEST) Message-ID: Date: Thu, 16 Jul 2026 10:05:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-access-control v5 3/7] test: add sdn acl pruning tests To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260707120404.73072-1-d.riley@proxmox.com> <20260707120404.73072-4-d.riley@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784189093310 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G27UCT7Z7WHN23XHKMKO4ZEEQSXUMNTM X-Message-ID-Hash: G27UCT7Z7WHN23XHKMKO4ZEEQSXUMNTM X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/16/26 9:33 AM, Daniel Kral wrote: > On Tue Jul 7, 2026 at 2:04 PM CEST, David Riley wrote: >> Add unit tests to validate the behavior of the SDN resource ACL >> pruning logic. >> >> The tests cover all designated SDN resource paths including zones, >> vnets (with/without tags), controllers, prefix-lists, route-maps, and >> fabrics, ensuring explicit permissions are dropped when resources are >> deleted. >> >> Signed-off-by: David Riley >> --- >> src/test/Makefile | 1 + >> src/test/sdn_acl_pruning_test.pl | 134 +++++++++++++++++++++++++++++++ >> 2 files changed, 135 insertions(+) >> create mode 100644 src/test/sdn_acl_pruning_test.pl >> >> diff --git a/src/test/Makefile b/src/test/Makefile >> index 53f2da7..2f44186 100644 >> --- a/src/test/Makefile >> +++ b/src/test/Makefile >> @@ -14,3 +14,4 @@ check: >> perl -I.. perm-test8.pl >> perl -I.. realm_sync_test.pl >> perl -I.. api-tests.pl >> + perl -I.. sdn_acl_pruning_test.pl >> diff --git a/src/test/sdn_acl_pruning_test.pl b/src/test/sdn_acl_pruning_test.pl >> new file mode 100644 >> index 0000000..f407c89 >> --- /dev/null >> +++ b/src/test/sdn_acl_pruning_test.pl >> @@ -0,0 +1,134 @@ >> +#!/usr/bin/env perl >> + >> +use v5.36; >> +use strict; >> +use warnings; > nit: sorry should have said that in my previous review, but 'use v5.36' > already implies the 'use strict' and 'use warnings', so the latter > two are not needed anymore > > same for the other test patch Alright, thanks for the heads up. No worries, I'll adapt it in v6. > >> + >> +use lib qw(..); >> + > [ snip ] > > > >