public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "David Riley" <d.riley@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-access-control v5 3/7] test: add sdn acl pruning tests
Date: Thu, 16 Jul 2026 09:32:47 +0200	[thread overview]
Message-ID: <DJZTKDDB5ESF.2RX72IOBZLTND@proxmox.com> (raw)
In-Reply-To: <20260707120404.73072-4-d.riley@proxmox.com>

On Tue Jul 7, 2026 at 2:04 PM CEST, David Riley wrote:
> Add unit tests to validate the behavior of the SDN resource ACL
> pruning logic.
>
> The tests cover all designated SDN resource paths including zones,
> vnets (with/without tags), controllers, prefix-lists, route-maps, and
> fabrics, ensuring explicit permissions are dropped when resources are
> deleted.
>
> Signed-off-by: David Riley <d.riley@proxmox.com>
> ---
>  src/test/Makefile                |   1 +
>  src/test/sdn_acl_pruning_test.pl | 134 +++++++++++++++++++++++++++++++
>  2 files changed, 135 insertions(+)
>  create mode 100644 src/test/sdn_acl_pruning_test.pl
>
> diff --git a/src/test/Makefile b/src/test/Makefile
> index 53f2da7..2f44186 100644
> --- a/src/test/Makefile
> +++ b/src/test/Makefile
> @@ -14,3 +14,4 @@ check:
>  	perl -I.. perm-test8.pl
>  	perl -I.. realm_sync_test.pl
>  	perl -I.. api-tests.pl
> +	perl -I.. sdn_acl_pruning_test.pl
> diff --git a/src/test/sdn_acl_pruning_test.pl b/src/test/sdn_acl_pruning_test.pl
> new file mode 100644
> index 0000000..f407c89
> --- /dev/null
> +++ b/src/test/sdn_acl_pruning_test.pl
> @@ -0,0 +1,134 @@
> +#!/usr/bin/env perl
> +
> +use v5.36;
> +use strict;
> +use warnings;

nit: sorry should have said that in my previous review, but 'use v5.36'
     already implies the 'use strict' and 'use warnings', so the latter
     two are not needed anymore

same for the other test patch

> +
> +use lib qw(..);
> +

[ snip ]




  reply	other threads:[~2026-07-16  7:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 12:03 [PATCH access-control/network v5 0/7] fix #7520: sdn: prune orphaned ACLs and handle VNet migrations David Riley
2026-07-07 12:03 ` [PATCH pve-access-control v5 1/7] permission: add acl tree node parent lookup without node creation David Riley
2026-07-15 14:59   ` Stefan Hanreich
2026-07-16  7:31     ` David Riley
2026-07-07 12:03 ` [PATCH pve-access-control v5 2/7] fix #7520: sdn: add pruning SDN resources ACLs David Riley
2026-07-07 12:04 ` [PATCH pve-access-control v5 3/7] test: add sdn acl pruning tests David Riley
2026-07-16  7:32   ` Daniel Kral [this message]
2026-07-16  8:05     ` David Riley
2026-07-07 12:04 ` [PATCH pve-access-control v5 4/7] permission: add helper to check for active permissions David Riley
2026-07-07 12:04 ` [PATCH pve-access-control v5 5/7] fix #7520: sdn: add VNet ACL migration David Riley
2026-07-15 14:59   ` Stefan Hanreich
2026-07-16  7:25     ` David Riley
2026-07-07 12:04 ` [PATCH pve-access-control v5 6/7] test: add sdn acl migration tests David Riley
2026-07-07 12:04 ` [PATCH pve-network v5 7/7] fix #7520: config: prune orphaned and relocate moved VNet ACLs David Riley
2026-07-15 15:00   ` Stefan Hanreich
2026-07-16  7:11     ` David Riley
2026-07-15 15:11 ` [PATCH access-control/network v5 0/7] fix #7520: sdn: prune orphaned ACLs and handle VNet migrations Stefan Hanreich
2026-07-16 10:47 ` superseded: " David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJZTKDDB5ESF.2RX72IOBZLTND@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal