From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-network 06/16] evpn controller: allow multiple evpn controllers in a cluster
Date: Thu, 16 Apr 2026 17:38:21 +0200 [thread overview]
Message-ID: <b6fa1c5e-92c9-4d62-8aa2-6401cfa8a30c@proxmox.com> (raw)
In-Reply-To: <5lb37bax6ickaa5gxo2xy7457fjghbtxwwngikkk27buyog5a7@3k3jx3x6oao7>
On 4/16/26 5:32 PM, Gabriel Goller wrote:
> On 16.04.2026 17:30, Hannes Laimer wrote:
>> On 2026-04-14 18:33, Stefan Hanreich wrote:
>> if one has none, so the default('VTEP'), and the other sets 'VTEP', we
>> miss that case here I think. something like
>> ```
>> my $pg_self = $controller->{'peer-group-name'} // 'VTEP';
>> my $pg_other = $other_controller->{'peer-group-name'} // 'VTEP';
>> die "cannot have two controllers with ..." if $pg_self eq $pg_other;
>> ```
>> might be better
>
> Maybe tangentially related: we should probably disallow VTEP as a bgp fabric
> name.
good catch! i'll fix it in the next version!
next prev parent reply other threads:[~2026-04-16 15:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 16:32 [RFC docs/manager/network/proxmox-ve-rs 00/16] Extend EVPN controller functionality Stefan Hanreich
2026-04-14 16:32 ` [PATCH proxmox-ve-rs 01/16] frr: add local-as setting Stefan Hanreich
2026-04-14 16:32 ` [PATCH proxmox-ve-rs 02/16] frr: add support for extcommunity lists Stefan Hanreich
2026-04-16 15:54 ` Hannes Laimer
2026-04-14 16:33 ` [PATCH proxmox-ve-rs 03/16] frr-templates: render local-as setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH proxmox-ve-rs 04/16] frr-templates: render community lists in templates Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 05/16] evpn controller: make nodes configurable Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 06/16] evpn controller: allow multiple evpn controllers in a cluster Stefan Hanreich
2026-04-16 15:30 ` Hannes Laimer
2026-04-16 15:34 ` Gabriel Goller
2026-04-16 15:38 ` Stefan Hanreich [this message]
2026-04-14 16:33 ` [PATCH pve-network 07/16] evpn controller: add bgp-mode setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 08/16] evpn zone: add secondary-controllers and rt filtering Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 09/16] evpn controller: add ebgp-multihop setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 10/16] test: evpn: add test for ibgp + ebgp evpn controller Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 11/16] test: evpn: add legacy test Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 12/16] tests: evpn: force ibgp over ebgp bgp controller with ebgp wan session Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 13/16] tests: test route filtering mechanism with multiple zones/controllers Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-manager 14/16] sdn: evpn: zone: controller: add new advanced fields Stefan Hanreich
2026-04-16 15:52 ` Hannes Laimer
2026-04-14 16:33 ` [PATCH pve-docs 15/16] sdn: evpn: document new zone / controller options Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-docs 16/16] sdn: fix typo in bgp controller Stefan Hanreich
2026-04-16 16:22 ` [RFC docs/manager/network/proxmox-ve-rs 00/16] Extend EVPN controller functionality Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fa1c5e-92c9-4d62-8aa2-6401cfa8a30c@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox