public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager 14/16] sdn: evpn: zone: controller: add new advanced fields
Date: Thu, 16 Apr 2026 17:52:20 +0200	[thread overview]
Message-ID: <4d1e5711-09a8-493d-9506-a14f8474100d@proxmox.com> (raw)
In-Reply-To: <20260414163315.419384-15-s.hanreich@proxmox.com>

On 2026-04-14 18:32, Stefan Hanreich wrote:
> Several new fields for configuring additional aspects of the EVPN
> controller/zone have been added to the backend. Expose them here
> additionally as advanced fields. For more information on the
> functionality of the fields, see the respective commits in
> pve-network.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---

[..]

> +            {
> +                xtype: 'proxmoxintegerfield',
> +                name: 'ebgp-multihop',
> +                minValue: 1,
> +                maxValue: 100,
> +                fieldLabel: 'ebgp-multihop',

nit: missing `gettext(..)`

> +                allowBlank: true,
> +                deleteEmpty: !me.isCreate,
> +            },
> +        ];
> +

[..]

> +        me.advancedItems = [
> +            {
> +                xtype: 'pveSDNControllerSelector',
> +                fieldLabel: gettext('additional Controllers'),

nit: a -> A

> +                name: 'secondary-controllers',
> +                allowBlank: true,
> +                multiSelect: true,
> +                skipEmptyText: true,
> +                deleteEmpty: !me.isCreate,
> +            },
> +        ];
> +
>          me.callParent();
>      },
>  });





  reply	other threads:[~2026-04-16 15:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 16:32 [RFC docs/manager/network/proxmox-ve-rs 00/16] Extend EVPN controller functionality Stefan Hanreich
2026-04-14 16:32 ` [PATCH proxmox-ve-rs 01/16] frr: add local-as setting Stefan Hanreich
2026-04-14 16:32 ` [PATCH proxmox-ve-rs 02/16] frr: add support for extcommunity lists Stefan Hanreich
2026-04-16 15:54   ` Hannes Laimer
2026-04-14 16:33 ` [PATCH proxmox-ve-rs 03/16] frr-templates: render local-as setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH proxmox-ve-rs 04/16] frr-templates: render community lists in templates Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 05/16] evpn controller: make nodes configurable Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 06/16] evpn controller: allow multiple evpn controllers in a cluster Stefan Hanreich
2026-04-16 15:30   ` Hannes Laimer
2026-04-16 15:34     ` Gabriel Goller
2026-04-16 15:38       ` Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 07/16] evpn controller: add bgp-mode setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 08/16] evpn zone: add secondary-controllers and rt filtering Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 09/16] evpn controller: add ebgp-multihop setting Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 10/16] test: evpn: add test for ibgp + ebgp evpn controller Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 11/16] test: evpn: add legacy test Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 12/16] tests: evpn: force ibgp over ebgp bgp controller with ebgp wan session Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-network 13/16] tests: test route filtering mechanism with multiple zones/controllers Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-manager 14/16] sdn: evpn: zone: controller: add new advanced fields Stefan Hanreich
2026-04-16 15:52   ` Hannes Laimer [this message]
2026-04-14 16:33 ` [PATCH pve-docs 15/16] sdn: evpn: document new zone / controller options Stefan Hanreich
2026-04-14 16:33 ` [PATCH pve-docs 16/16] sdn: fix typo in bgp controller Stefan Hanreich
2026-04-16 16:22 ` [RFC docs/manager/network/proxmox-ve-rs 00/16] Extend EVPN controller functionality Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d1e5711-09a8-493d-9506-a14f8474100d@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal