From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E3C2B1FF13C for ; Thu, 16 Apr 2026 17:52:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA340BA72; Thu, 16 Apr 2026 17:52:25 +0200 (CEST) Message-ID: <4d1e5711-09a8-493d-9506-a14f8474100d@proxmox.com> Date: Thu, 16 Apr 2026 17:52:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager 14/16] sdn: evpn: zone: controller: add new advanced fields To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260414163315.419384-1-s.hanreich@proxmox.com> <20260414163315.419384-15-s.hanreich@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260414163315.419384-15-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776354662058 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: L2BFZXE3G6UN3WO3P5QQBIRSTMMXA5FK X-Message-ID-Hash: L2BFZXE3G6UN3WO3P5QQBIRSTMMXA5FK X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-04-14 18:32, Stefan Hanreich wrote: > Several new fields for configuring additional aspects of the EVPN > controller/zone have been added to the backend. Expose them here > additionally as advanced fields. For more information on the > functionality of the fields, see the respective commits in > pve-network. > > Signed-off-by: Stefan Hanreich > --- [..] > + { > + xtype: 'proxmoxintegerfield', > + name: 'ebgp-multihop', > + minValue: 1, > + maxValue: 100, > + fieldLabel: 'ebgp-multihop', nit: missing `gettext(..)` > + allowBlank: true, > + deleteEmpty: !me.isCreate, > + }, > + ]; > + [..] > + me.advancedItems = [ > + { > + xtype: 'pveSDNControllerSelector', > + fieldLabel: gettext('additional Controllers'), nit: a -> A > + name: 'secondary-controllers', > + allowBlank: true, > + multiSelect: true, > + skipEmptyText: true, > + deleteEmpty: !me.isCreate, > + }, > + ]; > + > me.callParent(); > }, > });