From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id A0CAB1FF13C
	for <inbox@lore.proxmox.com>; Thu, 16 Apr 2026 17:38:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5CE82B708;
	Thu, 16 Apr 2026 17:38:54 +0200 (CEST)
Message-ID: <b6fa1c5e-92c9-4d62-8aa2-6401cfa8a30c@proxmox.com>
Date: Thu, 16 Apr 2026 17:38:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-network 06/16] evpn controller: allow multiple evpn
 controllers in a cluster
To: Hannes Laimer <h.laimer@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260414163315.419384-1-s.hanreich@proxmox.com>
 <20260414163315.419384-7-s.hanreich@proxmox.com>
 <b52973c6-311c-497a-8846-6dc324ea6922@proxmox.com>
 <5lb37bax6ickaa5gxo2xy7457fjghbtxwwngikkk27buyog5a7@3k3jx3x6oao7>
Content-Language: en-US
From: Stefan Hanreich <s.hanreich@proxmox.com>
In-Reply-To: <5lb37bax6ickaa5gxo2xy7457fjghbtxwwngikkk27buyog5a7@3k3jx3x6oao7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.688 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: CJRC3OA4GXAGETZM22G45WJM5ONVUC6J
X-Message-ID-Hash: CJRC3OA4GXAGETZM22G45WJM5ONVUC6J
X-MailFrom: s.hanreich@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>



On 4/16/26 5:32 PM, Gabriel Goller wrote:
> On 16.04.2026 17:30, Hannes Laimer wrote:
>> On 2026-04-14 18:33, Stefan Hanreich wrote:
>> if one has none, so the default('VTEP'), and the other sets 'VTEP', we
>> miss that case here I think. something like
>> ```
>>     my $pg_self = $controller->{'peer-group-name'} // 'VTEP';
>>     my $pg_other = $other_controller->{'peer-group-name'} // 'VTEP';
>>     die "cannot have two controllers with ..." if $pg_self eq $pg_other;
>> ```
>> might be better
> 
> Maybe tangentially related: we should probably disallow VTEP as a bgp fabric
> name.

good catch! i'll fix it in the next version!