* [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional
@ 2026-09-04 9:17 Gabriel Goller
2026-10-16 8:37 ` Gabriel Goller
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2026-09-04 9:17 UTC (permalink / raw)
To: pve-devel
The hostname is optional, it is usually passed on BGP Open, but that
doesn't have to be. Even though we always use the ip and not the
hostname, this can make parsing fail.
See:
https://github.com/FRRouting/frr/blob/b8316e31cb8b7caeed43ce363b0616e15a2acf15/bgpd/bgp_vty.c#L14674
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
proxmox-frr/src/de/evpn.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-frr/src/de/evpn.rs b/proxmox-frr/src/de/evpn.rs
index 942aecf367ee..ea67c7cc9497 100644
--- a/proxmox-frr/src/de/evpn.rs
+++ b/proxmox-frr/src/de/evpn.rs
@@ -98,7 +98,7 @@ pub struct Nexthop {
/// IP of the nexthop
pub ip: IpAddr,
/// Hostname of the nexthop
- pub hostname: String,
+ pub hostname: Option<String>,
/// Afi of the ip
pub afi: Option<Protocol>,
/// Used
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional
2026-09-04 9:17 [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional Gabriel Goller
@ 2026-10-16 8:37 ` Gabriel Goller
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Goller @ 2026-10-16 8:37 UTC (permalink / raw)
To: pve-devel
ping
On 04.09.2026 11:17, Gabriel Goller wrote:
> The hostname is optional, it is usually passed on BGP Open, but that
> doesn't have to be. Even though we always use the ip and not the
> hostname, this can make parsing fail.
>
> See:
> https://github.com/FRRouting/frr/blob/b8316e31cb8b7caeed43ce363b0616e15a2acf15/bgpd/bgp_vty.c#L14674
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> proxmox-frr/src/de/evpn.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-frr/src/de/evpn.rs b/proxmox-frr/src/de/evpn.rs
> index 942aecf367ee..ea67c7cc9497 100644
> --- a/proxmox-frr/src/de/evpn.rs
> +++ b/proxmox-frr/src/de/evpn.rs
> @@ -98,7 +98,7 @@ pub struct Nexthop {
> /// IP of the nexthop
> pub ip: IpAddr,
> /// Hostname of the nexthop
> - pub hostname: String,
> + pub hostname: Option<String>,
> /// Afi of the ip
> pub afi: Option<Protocol>,
> /// Used
> --
> 2.47.3
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-16 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-04 9:17 [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional Gabriel Goller
2026-10-16 8:37 ` Gabriel Goller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox