From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id BA1A01FF0B7
	for <inbox@lore.proxmox.com>; Fri, 16 Oct 2026 10:37:39 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 83C53214CB;
	Fri, 16 Oct 2026 10:37:36 +0200 (CEST)
Date: Fri, 16 Oct 2026 10:37:30 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname
 optional
Message-ID: <atHiP_c-H1yfqsOL@luna.proxmox.com>
References: <20260904091747.73474-1-g.goller@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20260904091747.73474-1-g.goller@proxmox.com>
User-Agent: NeoMutt/20260504
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792139851230
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.292 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: MUQ6BNWPFNUW4WJQYI37BO63DNEW4W2W
X-Message-ID-Hash: MUQ6BNWPFNUW4WJQYI37BO63DNEW4W2W
X-MailFrom: g.goller@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

ping

On 04.09.2026 11:17, Gabriel Goller wrote:
> The hostname is optional, it is usually passed on BGP Open, but that
> doesn't have to be. Even though we always use the ip and not the
> hostname, this can make parsing fail.
> 
> See:
> https://github.com/FRRouting/frr/blob/b8316e31cb8b7caeed43ce363b0616e15a2acf15/bgpd/bgp_vty.c#L14674
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-frr/src/de/evpn.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/proxmox-frr/src/de/evpn.rs b/proxmox-frr/src/de/evpn.rs
> index 942aecf367ee..ea67c7cc9497 100644
> --- a/proxmox-frr/src/de/evpn.rs
> +++ b/proxmox-frr/src/de/evpn.rs
> @@ -98,7 +98,7 @@ pub struct Nexthop {
>      /// IP of the nexthop
>      pub ip: IpAddr,
>      /// Hostname of the nexthop
> -    pub hostname: String,
> +    pub hostname: Option<String>,
>      /// Afi of the ip
>      pub afi: Option<Protocol>,
>      /// Used
> -- 
> 2.47.3
> 
> 
> 
> 
>