public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-sever] api: remove blank line
Date: Fri, 20 Nov 2026 08:45:40 +0100	[thread overview]
Message-ID: <DMZVDF3WDHPP.28VQ7ITHCS3SU@proxmox.com> (raw)
In-Reply-To: <29cdefbf-116f-4479-9758-be28bb2de91c@proxmox.com>

On Thu Nov 19, 2026 at 4:21 PM CET, Fiona Ebner wrote:
> Am 19.11.26 um 1:44 PM schrieb Dominik Rusovac:
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>>  src/PVE/API2/Qemu.pm | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
>> index b798a590..e8c93df6 100644
>> --- a/src/PVE/API2/Qemu.pm
>> +++ b/src/PVE/API2/Qemu.pm
>> @@ -2395,7 +2395,6 @@ my $update_vm_api = sub {
>>          }
>>  
>>          if ($param->{memory} || defined($param->{balloon})) {
>> -
>>              my $memory = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory};
>>              my $maxmem = get_current_memory($memory);
>>              my $balloon =
>
> Our codebase has quite a few occurrences of such blank lines at the
> start of branches. AFAICS, neither our style guide nor our perltidy
> config enforce their absence. If we do want to change it, we should do
> it there, and the next 'make tidy' will take care of it. Personally, I
> prefer not having blanks in such places, but I'm not sure we have
> consensus about that.

I do also prefer not having blanks in such places

just saw it by chance and thought I'd fix it in-place, but I agree with
your suggestion, which is more sustainable imo




  reply	other threads:[~2026-11-20  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 12:44 [PATCH qemu-sever] api: remove blank line Dominik Rusovac
2026-11-19 15:21 ` Fiona Ebner
2026-11-20  7:45   ` Dominik Rusovac [this message]
2026-11-20  7:49     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMZVDF3WDHPP.28VQ7ITHCS3SU@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal