From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Rusovac <d.rusovac@proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-sever] api: remove blank line
Date: Fri, 20 Nov 2026 08:49:27 +0100 [thread overview]
Message-ID: <e3e6fe1f-6614-4878-975d-66be398c9950@proxmox.com> (raw)
In-Reply-To: <DMZVDF3WDHPP.28VQ7ITHCS3SU@proxmox.com>
Am 20.11.26 um 08:45 schrieb Dominik Rusovac:
> On Thu Nov 19, 2026 at 4:21 PM CET, Fiona Ebner wrote:
>> Am 19.11.26 um 1:44 PM schrieb Dominik Rusovac:
>>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>>> ---
>>> src/PVE/API2/Qemu.pm | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
>>> index b798a590..e8c93df6 100644
>>> --- a/src/PVE/API2/Qemu.pm
>>> +++ b/src/PVE/API2/Qemu.pm
>>> @@ -2395,7 +2395,6 @@ my $update_vm_api = sub {
>>> }
>>>
>>> if ($param->{memory} || defined($param->{balloon})) {
>>> -
>>> my $memory = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory};
>>> my $maxmem = get_current_memory($memory);
>>> my $balloon =
>>
>> Our codebase has quite a few occurrences of such blank lines at the
>> start of branches. AFAICS, neither our style guide nor our perltidy
>> config enforce their absence. If we do want to change it, we should do
>> it there, and the next 'make tidy' will take care of it. Personally, I
>> prefer not having blanks in such places, but I'm not sure we have
>> consensus about that.
>
> I do also prefer not having blanks in such places
>
> just saw it by chance and thought I'd fix it in-place, but I agree with
> your suggestion, which is more sustainable imo
such things should be ideally pushed out directly. And ideally found and
fixed by auto-tooling so that one can fix them all at once not some one
by one. Might be that perltidy has an option for that, would be simplest
way, or one could probably come up with a sed command handling most cases.
prev parent reply other threads:[~2026-11-20 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 12:44 [PATCH qemu-sever] api: remove blank line Dominik Rusovac
2026-11-19 15:21 ` Fiona Ebner
2026-11-20 7:45 ` Dominik Rusovac
2026-11-20 7:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e6fe1f-6614-4878-975d-66be398c9950@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox